Repository navigation
fix(providers): support thinking toggle for Volcengine Ark (Doubao Seed) - #1193
Merged
Merged
Conversation
The Ark provider had no thinking-control dispatch: neither the provider-id
table nor the base_url fallback recognized it, so the thinking toggle in
settings was silently dropped. Doubao Seed 2.x models default to thinking
ON, adding several seconds of TTFT to every dictation-polish request even
when the user disabled thinking.
- Add ThinkingControl::VolcengineThinking sending Ark's official
thinking: { type: enabled | disabled } field
- Dispatch the ark / volcengine provider ids to it
- base_url fallback covers volces.com (Ark) and bytepluses.com (BytePlus
ModelArk, same Doubao Seed API)
- Tests cover the preset path and the custom-provider host fallback
Verified locally with doubao-seed-2-1-lite-260915: before the fix the
response stream carries reasoning_content despite the toggle being off;
with thinking.type=disabled the model answers directly.
HKLHaoBin
approved these changes
Oct 14, 2026
H-Chris233
added
area:provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Volcengine Ark (火山方舟) provider has no thinking-control dispatch:
openai_compatible_thinking_control()has no entry forark, and the base_url fallback doesn't recognizevolces.com. As a result the thinking toggle in settings is silently dropped for Ark.Doubao Seed 2.x models default to thinking on, so every dictation-polish request pays several seconds of extra TTFT (measured: ~3-4s first-token latency, response stream carries
reasoning_content) even when the user disabled thinking.Fix
ThinkingControl::VolcengineThinkingsending Ark's officialthinking: { "type": "enabled" | "disabled" }field (documented for Doubao Seed models, e.g.doubao-seed-2-1-lite,doubao-seed-2-0-mini)ark/volcengineprovider ids to itvolces.com(Ark CN) andbytepluses.com(BytePlus ModelArk — same Doubao Seed API)ark) and custom-provider host fallbackSame schema/literals as
DeepSeekThinking, but kept as a separate variant per the existing convention (cf.MiniMaxThinking) so channel defaults stay independent.Verification
cargo test -p openless-core --lib thinking— 19 passed, including the two new tests. Behavior verified end-to-end against the live Ark endpoint withdoubao-seed-2-1-lite-260915.