Skip to content

Fix calendar discovery for subscribed calendars - #474

Merged
veryCrunchy merged 7 commits into
mainfrom
fix/calendar-subscription-hrefs
Sep 17, 2026
Merged

veryCrunchy merged 7 commits into
mainfrom
fix/calendar-subscription-hrefs

Conversation

@veryCrunchy

Copy link
Copy Markdown
Member

Calendar discovery now uses the collection href from the DAV response itself, so external cs:source URLs on subscribed calendars cannot block loading.

Closes #472

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #474 / NC Native September 17, 2026 14:53 Destroyed
@obiente-cloud

obiente-cloud Bot commented Sep 17, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · b6ddc046d89a · Removed

View preview status

View in Obiente

Obiente updates this comment as the preview changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T16:11:18.646896Z b6ddc04 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 837d6f088a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/GroupwareDav.kt Outdated
Comment thread ui/src/commonTest/kotlin/dev/obiente/nextcloudnative/app/GroupwareDavTest.kt Outdated
Comment thread ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/GroupwareDav.kt Outdated
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #474 / NC Native September 17, 2026 15:00 Destroyed
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #474 / NC Native September 17, 2026 15:50 Destroyed
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #474 / NC Native September 17, 2026 15:55 Destroyed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b8a8b2da7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread website/public/screenshots/capture-manifest.json Outdated
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #474 / NC Native September 17, 2026 16:05 Destroyed
@veryCrunchy
veryCrunchy merged commit 575b512 into main Sep 17, 2026
6 checks passed
@veryCrunchy
veryCrunchy deleted the fix/calendar-subscription-hrefs branch September 17, 2026 16:28

This branch was successfully deployed

No deployments
Obiente Preview / PR #474 / NC Native b6ddc046 Deployed Sep 17, 2026 by obiente-cloud[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar discovery flags legitimate subscribed (webcal) calendars as "unsafe" DAV href

1 participant