Skip to content

fix(media): prevent duplicate workspace state on full-screen navigation - #468

Merged
veryCrunchy merged 4 commits into
mainfrom
fix/media-workspace-state
Sep 14, 2026
Merged

veryCrunchy merged 4 commits into
mainfrom
fix/media-workspace-state

Conversation

@veryCrunchy

@veryCrunchy veryCrunchy commented Sep 14, 2026

Copy link
Copy Markdown
Member

Opening or leaving full-screen media could register the same app workspace key twice during one Compose update and crash navigation. Move each workspace as one Compose subtree while keeping desktop chrome outside its state provider. Retain workspace-root settings across viewer navigation without restoring detail or editor state into a different record.

Advances #465. Related adaptive-layout audit findings are recorded in #148.

Validation: rendered Compose scene tests exercise real shell controls, independent app/sidebar state, repeated shell reparenting, returning from immersive media, and opening a different record. Both rendered scene tests and Android debug Kotlin compilation passed locally, along with Kotlin architecture and changelog validation. Hosted Linux and Windows CI passed, and Codex approved the code revision. The subsequent generated capture manifest changed only source hashes, which were independently verified. The PR is merged. No physical Android device validation or published release is claimed.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #468 / NC Native September 14, 2026 00:55 Destroyed
@obiente-cloud

obiente-cloud Bot commented Sep 14, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · f4487d5f0dc5 · Removed

View preview status

View in Obiente

Obiente updates this comment as the preview changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T02:30:49.664839Z 25018c4 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@veryCrunchy veryCrunchy added this to the 0.2 Safe sync and media milestone Sep 14, 2026
@veryCrunchy veryCrunchy added bug Something isn't working priority:P1 Required for the pre-release product experience area:media Media backup, MediaStore, storage reclaim, and sharing platform:android Android-specific implementation or validation platform:desktop Desktop-specific implementation or validation in-progress Implementation is currently active labels Sep 14, 2026
@veryCrunchy veryCrunchy moved this to In Progress in nati.ve Roadmap Sep 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ac8406038

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudNativeApp.kt Outdated
Comment thread ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudNativeApp.kt Outdated
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #468 / NC Native September 14, 2026 01:02 Destroyed
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #468 / NC Native September 14, 2026 02:26 Destroyed
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #468 / NC Native September 14, 2026 02:32 Destroyed
@veryCrunchy
veryCrunchy merged commit f0d71a9 into main Sep 14, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in nati.ve Roadmap Sep 14, 2026

This branch was successfully deployed

No deployments
Obiente Preview / PR #468 / NC Native f4487d5f Deployed Sep 14, 2026 by obiente-cloud[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:media Media backup, MediaStore, storage reclaim, and sharing bug Something isn't working in-progress Implementation is currently active platform:android Android-specific implementation or validation platform:desktop Desktop-specific implementation or validation priority:P1 Required for the pre-release product experience

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant