fix(media): prevent duplicate workspace state on full-screen navigation - #468
Conversation
Obiente previewNC Native · Obiente updates this comment as the preview changes. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ac8406038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Opening or leaving full-screen media could register the same app workspace key twice during one Compose update and crash navigation. Move each workspace as one Compose subtree while keeping desktop chrome outside its state provider. Retain workspace-root settings across viewer navigation without restoring detail or editor state into a different record.
Advances #465. Related adaptive-layout audit findings are recorded in #148.
Validation: rendered Compose scene tests exercise real shell controls, independent app/sidebar state, repeated shell reparenting, returning from immersive media, and opening a different record. Both rendered scene tests and Android debug Kotlin compilation passed locally, along with Kotlin architecture and changelog validation. Hosted Linux and Windows CI passed, and Codex approved the code revision. The subsequent generated capture manifest changed only source hashes, which were independently verified. The PR is merged. No physical Android device validation or published release is claimed.