GlobToRegexFunctionType documentation updates required #245

Activity

1. iankko commented on Mar 18, 2015

   

   iankko

   on Mar 18, 2015

   More actions

   Thank you for filing this ticket, David.

   Further issue details (to document what is currently wrong). The current (OVAL 5.11) glob_to_regex() function documentation provides couple of examples for different values of noescape attribute. Quoting relevant parts from current documentation:
       http://oval.mitre.org/language/version5.11/ovaldefinition/documentation/oval-definitions-schema.html#GlobToRegexFunctionType

   For example given the input glob pattern would be '\*' then the resulting Perl 5's regular
   expression would be '^\\.*$' in the default (glob_noescape=false) case (here '\' would be
   interpreted as an escape character), and would produce '^\.*$' in glob_noescape=true case
   (since here '\' would be interpreted as an literal). Similarly the output for '\?' glob
   pattern would be '^\\.$' (default,  glob_noescape=false case), and '^\.$' for
   glob_noescape=true case.
   

   As correctly pointed out by David via the link above, the resulting form of examples is incorrect now.

   The correct version should be:

   # Results for C '\*' glob:
   ----------------------------------------
     glob_noescape  | Perl regular expression
   ----------------------------------------
         FALSE           |      ^\*$
          TRUE           |     ^\\.*$
   ----------------------------------------
   
   # Results for C '\?' glob:
   ----------------------------------------
     glob_noescape | Perl regular expression
   ----------------------------------------
        FALSE           |      ^\?$
         TRUE           |      ^\\.$
   ---------------------------------------- 
   

   And to provide yet one example for handling of '[' and ']' characters it's listed below:

   # Results for C '\[hello\]' glob:
   ----------------------------------------
     glob_noescape | Perl regular expression
   ----------------------------------------
        FALSE           | ^\[hello\]$
         TRUE            | ^\\[hello\\]$ 
   

   I will create & attach corresponding OVAL Language git repository changes & add a diff here.

   Thank you && Regards, Jan.
   Jan iankko Lieskovsky
2. drothenberg

   added a commit that references this issue on Mar 24, 2015

   5.11.1 Core Fixes

   ...

   This issue will close once commit 965aed6 is merged into the 'master' branch.

   965aed6
3. drothenberg

   added this to the 5.11.1 milestone on Apr 10, 2015
4. drothenberg

   closed this as completedin 965aed6on Apr 22, 2015