[IMP] report_qweb_pdf_watermark: extract _get_watermark method - #1195
Open
AnmollGarg wants to merge 1 commit into
Open
[IMP] report_qweb_pdf_watermark: extract _get_watermark method#1195AnmollGarg wants to merge 1 commit into
AnmollGarg wants to merge 1 commit into
Conversation
Contributor
|
Hi @hbrunn, |
OCA-git-bot
added
series:18.0
mod:report_qweb_pdf_watermark
AnmollGarg
force-pushed
the
fix_report_qweb_pdf_watermark
branch
from
September 11, 2026 08:54
c0ef5b8 to
70bd318
Compare
hbrunn
approved these changes
Sep 11, 2026
hbrunn
left a comment
hbrunn
left a comment
Member
There was a problem hiding this comment.
I've have expected that those cases use an expression and some custom function, but don't mind this refactoring
AnmollGarg
force-pushed
the
fix_report_qweb_pdf_watermark
branch
from
September 11, 2026 15:29
4866edc to
b6f4cc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts watermark resolution logic from
_run_wkhtmltopdfinto a dedicated_get_watermark(report_ref, docids=False)method.This provides a clean hook for downstream modules to inject custom watermarks without duplicating PDF processing logic.