Skip to content

[IMP][16.0+] base_import_async: propagate context used during import #710

Description

@AnizR

Context

I was doing an asynchronous import on "account.asset" and realized that my assets were created but not visible.
After some investigation, I found that that it was caused by a field 'asset_type' that is set using the context key 'default_asset_type'

Proposition

I think that the context used during import should be propagate to the jobs created.
Or, at least, every key starting by 'default_...' .

It could be easily done by modifying the function on base_import.import:

def _job_prepare_context_before_enqueue_keys(self):

Question

Since I know that it could generate a debate, I opened this issue before creating any PR.

Should we propagate the context? All of it? A sub part of it?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementstalePR/Issue without recent activity, it'll be soon closed automatically.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions