Repository navigation
Conversation
This was referenced Oct 17, 2026
Member
Author
|
Review findings (design, tmech expressions instead of component loops, modern C++, comments, tests, correctness). Severity: must = wrong result, hang, build break or unreachable feature; should = design, duplication, accuracy; nit = style. Voigt composite wiring — ready (with one should)
|
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 17, 2026 14:51
b35575b to
68a6d39
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 17, 2026 15:01
3d2fd8e to
4e92931
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 17, 2026 16:16
68a6d39 to
d920fb3
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 17, 2026 16:16
4e92931 to
bf49f47
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 17, 2026 17:22
d920fb3 to
fdaa5f7
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 17, 2026 17:22
bf49f47 to
e5e56ce
Compare
Member
Author
|
Rebased: the linear reference is a |
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 17, 2026 21:44
fdaa5f7 to
00adc74
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 17, 2026 21:44
e5e56ce to
3693657
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 17, 2026 22:46
00adc74 to
439b34d
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 17, 2026 22:46
3693657 to
d067a3e
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 18, 2026 13:13
439b34d to
c81bf8f
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 18, 2026 13:25
d067a3e to
a586b3c
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 18, 2026 13:38
c81bf8f to
d9a9773
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 18, 2026 13:38
a586b3c to
6cd5670
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 18, 2026 18:55
d9a9773 to
76c0d56
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 18, 2026 18:55
6cd5670 to
8a28695
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 18, 2026 20:03
76c0d56 to
083302e
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 18, 2026 20:03
8a28695 to
11c29c7
Compare
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 18, 2026 20:22
083302e to
b6f2221
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 18, 2026 20:22
11c29c7 to
a5df503
Compare
Every phase reads the composite strain; weighted_sum with constant_scalar fractions gives the Voigt stress and the consistent tangent. Tested with a J2 and an elastic phase under uniaxial stress against the weighted phase stresses and against rule_of_mixture while elastic.
petlenz
force-pushed
the
feature/uvwmaterial-mapping
branch
from
October 19, 2026 04:07
b6f2221 to
98ec074
Compare
petlenz
force-pushed
the
feature/voigt-composite
branch
from
October 19, 2026 04:07
a5df503 to
53d3c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #117 (the Voigt half) and of the uvwmaterial port (#94); stacked on #139.
small_strain_rule_of_mixture_historywith the Voigt kernel (equal strain in every phase, history per phase) needs no new material: each phase reads the composite strain source, andweighted_sumwithconstant_scalarfractions produces Σ cᵢ σᵢ and Σ cᵢ Cᵢ — the consistent Voigt tangent. This PR pins that with tests and documents it in the mapping.Tests (
test_voigt_composite, 2): a J2 phase and an elastic phase under uniaxial stress through the driver — the composite stress equals the fraction-weighted phase stresses at every step while the plastic phase yields, and the tangent matches central differences to 1e-6; while elastic the wiring equals the linear rule of mixtures (phasenodes on the two tangents,rule_of_mixturevoigt,linear_stress) in stress and tangent.Not in this PR: the Reuss kernel (equal stress, phase strains from an inner Newton with history) waits for the vector Newton work in flight; and
weighted_sumcannot be written in JSON yet because the parameter converter has no reader for itsterms(vector of string pairs), so there is no report for this wiring — both noted on #117. The converter (#139) emits the same Voigt wiring asrule_of_mixture+mean_field_stressfor a card with a nonlinear phase.942/942 tests pass (GCC 14, reports on).