Repository navigation
Conversation
This was referenced Oct 16, 2026
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 16, 2026 23:43
f56825b to
515796b
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 16, 2026 23:43
c660cef to
4a060f0
Compare
Member
Author
|
Review findings (design, tmech expressions instead of component loops, modern C++, comments, tests, correctness). Severity: must = wrong result, hang, build break or unreachable feature; should = design, duplication, accuracy; nit = style. curing fractions / chemical shrinkage — ready with one should
|
This was referenced Oct 17, 2026
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
2 times, most recently
from
October 17, 2026 14:31
e4f80c1 to
316263a
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 17, 2026 14:40
4a060f0 to
bd0004d
Compare
Member
Author
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 17, 2026 15:57
316263a to
9928a69
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 17, 2026 16:05
bd0004d to
6eff511
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 17, 2026 17:04
9928a69 to
971cf5a
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 17, 2026 17:12
6eff511 to
30fbcba
Compare
Member
Author
|
Producer/consumer pass: the curing inclusion gives its fraction only through |
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 17, 2026 21:36
971cf5a to
6966212
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 17, 2026 21:36
30fbcba to
bc568df
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 17, 2026 22:46
6966212 to
5463017
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 17, 2026 22:46
bc568df to
f964442
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 18, 2026 12:32
5463017 to
8558f90
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 18, 2026 12:51
f964442 to
a4bd728
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 18, 2026 13:38
8558f90 to
e2a4434
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 18, 2026 13:38
a4bd728 to
4c1aac1
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 18, 2026 18:55
e2a4434 to
39adb32
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 18, 2026 18:56
4c1aac1 to
93a893f
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 18, 2026 20:03
39adb32 to
2afbfb9
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 18, 2026 20:03
93a893f to
8a07c8c
Compare
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 18, 2026 20:22
2afbfb9 to
e7d2ffe
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 18, 2026 20:22
8a07c8c to
e1819c4
Compare
inclusion takes a fraction_source ("material::property") so the volume
fraction can follow the degree of cure; the chemical shrinkage
beta xi I is thermal_eigenstrain with the cure state as its source.
petlenz
force-pushed
the
feature/kamal-sourour-rate
branch
from
October 19, 2026 04:07
e7d2ffe to
9037f62
Compare
petlenz
force-pushed
the
feature/curing-eigenstrain
branch
from
October 19, 2026 04:07
e1819c4 to
9af23f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115. Part of the uvwmaterial port (#94); stacked on #136.
uvwmaterial's
eigenstrain_curing_material_baseanddegree_of_cure_dependent_materialbecome two wirings rather than classes:thermal_eigenstrainwith the degree of cure as its scalar source ("temperature_source": "cure","alpha": beta, reference 0); the integrator'sstateis a history like a temperature source's. Nothing new to port; the test pins it.phasereads its fraction from any producer (fraction_source/fraction_property, e.g."cure","state"of ascalar_stepperor aweighted_sumoutput); itsvolume_fractionoutput follows that property every update,scalar_complement_weightproduces the matrix fraction 1 − c, andmean_field_tangentreads both. Cure-dependent moduli already go throughweighted_sum.Tests (
test_curing_eigenstrain, 3): the phase fraction follows its source and the Mori–Tanaka bulk modulus follows the analytic formula at each value; constrained shrinkage gives −3Kβξ;fraction_sourcefrom JSON.No report yet (time-driven point, #126).
924/924 tests pass (GCC 14, reports on).