vsimd: add missing #[inline(always)] to unified::max - #79
Merged
Conversation
Signed-off-by: lxl66566 <lxl66566@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unified::maxwas the only function inunified.rsmissing#[inline(always)]. LLVM does not reliably inline it in downstream generic contexts.In
unicode-simd'sis_utf32le(AVX2 path), the per-32B-chunk call tovsimd::unified::max::<AVX2, u32, V256>was not inlined when the downstream crate is built with global-C target-feature=+avx2: the hot loop issues an indirect call per chunk, with the 32-byte vector args/result spilled through the stack.Benchmark on AMD Zen 4,
unicode_simd::is_utf32leon 64 KiB,-C target-feature=+sse4.1,+avx2