Skip to content

Remove unused devtool dependencies; fix undeclared phantom deps #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwertheimer merged 2 commits into from
Jul 30, 2026
+3,338 −5,948
Merged

Remove unused devtool dependencies; fix undeclared phantom deps #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f02194
Remove unused devtool dependencies; fix undeclared phantom deps
dwertheimer Jul 30, 2026
bf016c8
Drop --legacy-peer-deps now that rollup-plugin-styles is gone
dwertheimer Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ jobs:
cache: 'npm'
- name: Disable optional dependencies # work around git bug on macos arm64 dependencies
run: export NPM_CONFIG_OPTIONAL=false
# shoulde eventually be a clean install using: - run: npm ci --legacy-peer-deps
# - run: npm i -g node-gyp@latest && npm config set node_gyp "/usr/local/lib/node_modules/node-gyp/bin/node-gyp.js"
- run: npm ci --legacy-peer-deps # clean install (deletes node_modules)
- run: npm ci # clean install (deletes node_modules)
- run: npm link # necessary for some reason specific to NP dev setup
# note: when upgrade to node 16+, add this to the following --max-old-space-size=8192
- run: NODE_OPTIONS=--max-old-space-size=8192 npm run test:ci # run Jest CI version and stop if errors
Expand Down Expand Up @@ -92,9 +91,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
# shoulde eventually be a clean install using: - run: npm ci --legacy-peer-deps
# - run: npm i -g node-gyp@latest && npm config set node_gyp "/usr/local/lib/node_modules/node-gyp/bin/node-gyp.js"
- run: npm ci --legacy-peer-deps # clean install (deletes node_modules)
- run: npm ci # clean install (deletes node_modules)
- run: npm link # necessary for some reason specific to NP dev setup
# note: when upgrade to node 16+, add this to the following --max-old-space-size=8192
- run: NODE_OPTIONS=--max-old-space-size=8192 node scripts/rollup.js -b -ci # build all plugins and stop if errors
Expand Down
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ Run the following 2 commands from the root of your local GitHub repository for `
npm install
```

> **NOTE**: if you are running node >= 16 and you get failure messages on the vanilla install command above, you will need to use this command instead: `npm install --legacy-peer-deps`

2) Link the files to make them run properly from the command line (especially the `noteplan-cli`)

```shell
Expand Down
Loading