Skip to content

Zooming in GUI models (possibly in headless models too?) - #42

Merged
qiemem merged 1 commit into
masterfrom
zoomable-gui-models
May 22, 2016
Merged

Zooming in GUI models (possibly in headless models too?)#42
qiemem merged 1 commit into
masterfrom
zoomable-gui-models

Conversation

@mrerrormessage

@mrerrormessage mrerrormessage commented May 21, 2015

Copy link
Copy Markdown
Contributor

Should we allow headless models' image frame to zoom too?

@arthurhjorth arthurhjorth assigned arthurhjorth and unassigned qiemem Feb 5, 2015
@mrerrormessage

mrerrormessage commented May 18, 2015

Copy link
Copy Markdown
Contributor

InterfacePanelLite looks different from WidgetPanel. resetZoomInfo is used by the widgets to add themselves to the zoomer’s list of widgets. I assume (I could be wrong) that there’s a reason the two implementations are different. We could override the way InterfacePanelLite works in a subclass, but that’s messy for a number of reasons, primarily because it’s constructed along with four other objects in InterfacePanel. I'll be working to get a fix into NetLogo 5.x/6.x that will allow this to work.

@mrerrormessage mrerrormessage added this to the IDC-RC1 milestone May 20, 2015
@mrerrormessage

mrerrormessage commented May 21, 2015

Copy link
Copy Markdown
Contributor

The corresponding NetLogo fix is at this PR

@mrerrormessage

mrerrormessage commented May 21, 2015

Copy link
Copy Markdown
Contributor

I'm not sure that this PR is pointed at the right branch.

@qiemem

qiemem commented May 22, 2015

Copy link
Copy Markdown
Member

Just to clarify, this relies on NetLogo/NetLogo#783 and should not be merged until that is, correct?

It might be worth extracting the GUIChildModel -> scala conversion to a separate PR so we can build stuff off that in the meantime.

1 similar comment
@qiemem

qiemem commented May 22, 2015

Copy link
Copy Markdown
Member

Just to clarify, this relies on NetLogo/NetLogo#783 and should not be merged until that is, correct?

It might be worth extracting the GUIChildModel -> scala conversion to a separate PR so we can build stuff off that in the meantime.

@mrerrormessage
Adds LevelSpace zooming
7af147b 
- Converts GUIPanel, GUIChildModel to scala
- Adds ZoomableInterfaceComponent and friends
- Adds a ZoomMenu to the menu bar for LevelSpace frames
@qiemem

qiemem commented Jun 18, 2015

Copy link
Copy Markdown
Member

Oh, some of my comments in #43 belong here. Besides those, this looks good, though I only skimmed over the zooming code itself.

@qiemem
qiemem merged commit 7af147b into master May 22, 2016
@mrerrormessage
mrerrormessage deleted the zoomable-gui-models branch June 29, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mrerrormessage mrerrormessage

Labels

None yet

Projects

None yet

Milestone

IDC-RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@mrerrormessage @qiemem @arthurhjorth