bind916 - removed _XOPEN_SOURCE - socket.c

[russhan]

patches/patch-lib_isc_unix_socket.c appears to have lost the definition of _XOPEN_SOURCE required for SmartOS.

Specifically I believe this might be the culprit: ce4a3bf#diff-1285c7d3bbb0e62c17003e1f8bccc791851efd65b4cf340c3f24f69bc6b8099a

The consequence can be found at:
http://mail-index.netbsd.org/pkgsrc-bulk/2022/02/14/msg022049.html
https://us-east.manta.joyent.com/pkgsrc/public/reports/upstream-trunk/20220213.2256/bind-9.16.25/build.log

[sskras]

I wonder too, why was this piece removed:

---- lib/isc/unix/socket.c.orig 2021-05-12 09:53:16.000000000 +0000
+--- lib/isc/unix/socket.c.orig 2021-09-07 09:37:05.000000000 +0000
 +++ lib/isc/unix/socket.c
-@@ -11,6 +11,15 @@
-
- /*! \file */
-
-+/* needed for CMSG_DATA */
-+#if defined(__sun)
-+#if (__STDC_VERSION__ - 0 < 199901L)
-+#define _XOPEN_SOURCE 500
-+#else
-+#define _XOPEN_SOURCE 600
-+#endif
-+#endif
-+
- #include <inttypes.h>
- #include <stdbool.h>
- #include <sys/param.h>
-@@ -360,7 +369,11 @@ struct isc_socket {
 ...

[dhgutteridge]

AFAIK, this was simply caused by a merge botch, rather than it being removed intentionally. From what I see, since my update to restore that patch fragment (tracked via the PR pkg/56716 in NetBSD's Gnats system), @jperkin has made other unrelated fixes to this package as well, and it is now available in SmartOS bulk builds. I'm not able to close this issue here myself (GitHub is a read-only mirror of pkgsrc, and only a handful of commiters have admin rights here).