This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Webpack compilation doesn't stop on syntactic errors in js/vue apps #1067
Description
Environment
CLI: @next
Plugin(s): nativescript-dev-webpack@next
Describe the bug
webpack compilation doesn't stop on syntactic errors in js/vue apps
To Reproduce
tns create js_app --jsnpm i nativescript-dev-webpack@next --save-dev --save-exactnode_modules/.bin/update-ns-webpack --deps --configstns run iOS- In main-view-model.js make syntactic error (add additional " somewhere)
Result: webpack doesn't stop on error the app is deployed and crashes
Expected behavior
the build should stop on the error and app should not be deployed broken
Additional context
Not reproducible with nativescript-dev-webpack@1.2.1
It is reproducible with run android too
Activity
Fatme commentedon Oct 22, 2019
Currently CLI handles only
Module not founderrors (wrong require/import) in js/vue applications. This is due to the fact thatModule not founderrors are handled by webpack itself during the compilation.The
.jsfiles insidejs/vueapplications are processed usingraw-loader. It doesn't analyze the code, just copies the content of the file to bundle/vendor. However, using another loader (for example, eslint-loader) will resolve this problem as it'll analyze the code according the give options (.eslint file) and will report them to the webpack. That way, CLI will stop on syntax/semantic errors in js/vue apps.