Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

hmr hot update incorrectly transferred #1065

Open

Description

@endarova

Environment

  • CLI: @next
  • Plugin(s): nativescript-dev-webpack@next

To Reproduce

  1. tns create app --ng
  2. npm i nativescript-dev-webpack@next --save-dev --save-exact
  3. node_modules/.bin/update-ns-webpack --deps --configs
  4. tns run ios
  5. in app.module.ts change some of the imports to use invalid path
  6. the compilation stops on the error which is expected
  7. fix the error
    Observe the log:
    Webpack compilation complete. Watching for file changes.
    Webpack build done!
    Successfully transferred bundle.js on device emulator-5554.
    Successfully transferred runtime.js on device emulator-5554.
    Successfully transferred vendor.js on device emulator-5554.
    Successfully transferred 8e8d0cd48028dd74cb35.hot-update.json on device emulator-5554.
    JS: HMR: Checking for updates to the bundle with hmr hash 8e8d0cd48028dd74cb35.
    JS: HMR: No Modules Updated.
    JS: HMR: Successfully applied update with hmr hash 8e8d0cd48028dd74cb35. App is up to date.
    Restarting application on device emulator-5554...
    JS: HMR: Hot Module Replacement Enabled. Waiting for signal.

Note: 8e8d0cd48028dd74cb35.hot-update.json should not be transferred

Additional context
Not reproducible with nativescript-dev-webpack@1.2.1

Activity

  1. self-assigned this
    on Oct 18, 2019
  2. Fatme commented on Oct 22, 2019

    @Fatme
    Contributor

    However, it seems as a minor issue as actually the hmr chain is not broken.

  3. removed their assignment
    on Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions