Skip to content

fix(secret): rename the secret scan job to pulse-secret - #31

Merged
gmanal merged 1 commit into
mainfrom
fix/secret-scan-job-id
Nov 13, 2026
Merged

gmanal merged 1 commit into
mainfrom
fix/secret-scan-job-id

Conversation

@gmanal

@gmanal gmanal commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

The secret scan job is named pulse, while the other Pulse scans are named pulse-oss (vulnerability) and pulse-malware. This renames it to pulse-secret so all scan jobs follow the same naming and are easy to tell apart in the checks list.

Impact

  • No change to how the secret scan runs, its inputs or its results.
  • The status check name changes from … / pulse to … / pulse-secret. Repositories that list the old check as required in branch protection need to update it when they move to this version. Repositories pinned to an earlier commit are unaffected until they repin.

Validation

  • Existing workflow contract tests and lint checks pass.

@gmanal
gmanal merged commit 3119944 into main Nov 13, 2026
45 checks passed
gmanal added a commit that referenced this pull request Nov 13, 2026
Releases the two secret-scan changes that landed after v0.5.0: 
- the job rename to pulse-secret (#31)
- the shallow checkout for the filesystem scan (#28).

Minor rather than patch. Neither change touches the workflow_call interface, which by README's versioning rules would make this a patch, but the rename changes the downstream status-check name from `… / pulse` to
`… / pulse-secret`. 

Also moves the shallow-checkout entry out of [0.5.0]. It was added by #28 after v0.5.0 was stamped, so that tag carries neither the entry nor the change, and the released notes claimed a fix the release did not contain.
@gmanal
gmanal deleted the fix/secret-scan-job-id branch November 13, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant