chore(core): cover source cdn bundle entry in unit tests - #254
Merged
Conversation
imports the source bundle entry so istanbul records the global nve_elements.state.bundle assignment. line coverage rises from 0% to 100%. no public api or behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
coryrylan
approved these changes
Aug 28, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.6.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Coverage for
projects/core/src/bundle.ts.Selector rationale: "1 uncovered lines, 0% lines and 100% branches, the smallest gap below the 90% threshold".
The existing suite imported only
../dist/bundles/index.js, so istanbul never recorded the source entry.Measurement
projects/coreunit tests: 1888 passed, including the 3cdn bundlecases.Public API
No public API changed. Production
bundle.tsis untouched. Behavior is unchanged.Left alone
Validation
projects/core: lint, test, test:types, test:axe, test:ssr, test:lighthouse (78), test:visual, test:coveragepnpm run cigit diff --checkon the changed file