Skip to content

[no-ci] ci: exclude unavailable historical GitHub references - #3471

Merged
rwgk merged 2 commits into
mainfrom
rwgk/lychee-unavailable-github-links
Nov 16, 2026
Merged

rwgk merged 2 commits into
mainfrom
rwgk/lychee-unavailable-github-links

Conversation

@rwgk

@rwgk rwgk commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

— codex GPT-6 on behalf of Ralf —

Description

Historical release-note links to PR #2236 and issues #2344 and #2345 now return HTTP 404, causing unrelated PRs to fail Lychee checks. These were valid public references and passed fresh link validation before becoming unavailable.

Add the three exact URLs to the existing exclusions in lychee.toml, shared by authored and rendered documentation checks. Keep these exclusions permanently: later disappearance of known-valid historical GitHub content does not need to block CI. All other URLs remain checked.

Validation

  • pre-commit run --all-files --show-diff-on-failure passes, including live authored Lychee checks.
  • The TOML parses, all three intended URLs match, and seven nearby or unrelated URLs remain checked.
  • Independent review found no issues.

Checklist

  • I have read the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

rwgk added 2 commits November 16, 2026 09:58
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rwgk rwgk added the CI/CD CI/CD infrastructure label Nov 16, 2026
@rwgk rwgk self-assigned this Nov 16, 2026
@rwgk rwgk added this to the CI milestone Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Link checking now skips three unavailable GitHub references.

The Lychee exclude list now skips one GitHub pull request URL and two issue URLs. A comment states that these references became unavailable in November 2026.

Changes: Lychee URL exclusions

Layer / File(s) Summary
Exclude unavailable GitHub URLs
lychee.toml
The exclusion list adds the pull request URL ending in /pull/2236 and issue URLs ending in /issues/2344 and /issues/2345. A comment records that the references became unavailable in November 2026.

Suggested reviewers: mdboom

Change: Bug fix

Merge Risk: Minimal · up to 87d63

This change only stops link checks from failing on three historical GitHub references that now return 404. No runtime behavior is affected, and other links remain checked. The merge risk is minimal.

Architecture risk: Low · up to 87d63

The change affects 1 system.

Changed systems: lychee.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — lychee.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in lychee.toml: The exclude list adds three GitHub URLs: pull request 2236 and issues 2344 and 2345. The accompanying comment says the references became unavailable in November 2026.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between e7c34c8 and 87d6338.

Files selected for processing: 1

  • lychee.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@rwgk rwgk changed the title ci: exclude unavailable historical GitHub references [no-ci] ci: exclude unavailable historical GitHub references Nov 16, 2026
@rwgk

rwgk commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 87d6338

@rwgk
rwgk merged commit 3991a69 into main Nov 16, 2026
34 of 35 checks passed
@rwgk
rwgk deleted the rwgk/lychee-unavailable-github-links branch November 16, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants