Skip to content

test(cuda.core): skip HOST graph allocation before CUDA 13 - #3446

Merged
Andy-Jost merged 2 commits into
NVIDIA:mainfrom
rluo8:fix/nvbug-7080276-host-graph-precondition
Nov 17, 2026
Merged

Andy-Jost merged 2 commits into
NVIDIA:mainfrom
rluo8:fix/nvbug-7080276-host-graph-precondition

Conversation

@rluo8

@rluo8 rluo8 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Description

This is to fix internal bug 7080276.
The HOST graph allocation reconstruction test fails on CUDA 12.9 drivers with CUDA_ERROR_INVALID_VALUE: generic HOST pool properties are rejected before the graph-specific support check.

The fix is to skip this test when the runtime CUDA driver version is below 13.0. Keep the existing CUDA_ERROR_NOT_SUPPORTED handling and reconstruction assertions for newer drivers.

@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label Nov 11, 2026
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 018ee8a and c614b6a.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Tests
    • Updated test behavior to skip HOST graph allocation checks when the CUDA driver is older than version 13.0.

The HOST graph allocation test now skips when the CUDA driver version is below 13.0. It retains the existing skip for CUDA_ERROR_NOT_SUPPORTED during allocation.

Changes: HOST graph allocation test

Layer / File(s) Summary
Driver version guard
cuda_core/tests/graph/test_graph_definition.py
The test skips before attempting HOST graph allocation when the driver version is below 13.0.

Possibly related issues

Suggested reviewers: andy-jost

Change: Bug fix

Merge Risk: Minimal · previous review 018ee

This is a test-only change that skips a HOST graph allocation test on CUDA drivers older than 13.0. It has no production impact. The metadata CI check needs an assignee, labels and a milestone before merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 303fbda and 018ee8a.

Files selected for processing: 1

  • cuda_core/tests/graph/test_graph_definition.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@rluo8 rluo8 self-assigned this Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@rluo8
rluo8 requested a review from Andy-Jost November 12, 2026 01:29

@Andy-Jost Andy-Jost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. HOST-location pool properties need a CUDA 13.0 driver. On a 12.x driver the call fails with CUDA_ERROR_INVALID_VALUE before the driver reaches the graph check, so the existing NOT_SUPPORTED skip never applies. Gating on the driver version, not the build version, is the right condition. It is the same gate that test_pinned_memory_resource_rejects_unsupported_host_pool uses.

@Andy-Jost Andy-Jost added the test Improvements or additions to tests label Nov 16, 2026
@Andy-Jost Andy-Jost added this to the cuda.core 1.3.1 milestone Nov 16, 2026
@Andy-Jost Andy-Jost added the to-be-backported Trigger the bot to raise a backport PR upon merge label Nov 16, 2026
@Andy-Jost
Andy-Jost merged commit 11cc666 into NVIDIA:main Nov 17, 2026
118 of 119 checks passed
Andy-Jost pushed a commit to Andy-Jost/cuda-python that referenced this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module test Improvements or additions to tests to-be-backported Trigger the bot to raise a backport PR upon merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants