You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(cuda.core): skip HOST graph allocation before CUDA 13 - #3446
This is to fix internal bug 7080276.
The HOST graph allocation reconstruction test fails on CUDA 12.9 drivers with CUDA_ERROR_INVALID_VALUE: generic HOST pool properties are rejected before the graph-specific support check.
The fix is to skip this test when the runtime CUDA driver version is below 13.0. Keep the existing CUDA_ERROR_NOT_SUPPORTED handling and reconstruction assertions for newer drivers.
Reviewing files that changed from the base of the PR and between 018ee8a and c614b6a.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Tests
Updated test behavior to skip HOST graph allocation checks when the CUDA driver is older than version 13.0.
The HOST graph allocation test now skips when the CUDA driver version is below 13.0. It retains the existing skip for CUDA_ERROR_NOT_SUPPORTED during allocation.
Changes: HOST graph allocation test
Layer / File(s)
Summary
Driver version guard cuda_core/tests/graph/test_graph_definition.py
The test skips before attempting HOST graph allocation when the driver version is below 13.0.
This is a test-only change that skips a HOST graph allocation test on CUDA drivers older than 13.0. It has no production impact. The metadata CI check needs an assignee, labels and a milestone before merge.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 303fbda and 018ee8a.
Files selected for processing: 1
cuda_core/tests/graph/test_graph_definition.py
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Approving. HOST-location pool properties need a CUDA 13.0 driver. On a 12.x driver the call fails with CUDA_ERROR_INVALID_VALUE before the driver reaches the graph check, so the existing NOT_SUPPORTED skip never applies. Gating on the driver version, not the build version, is the right condition. It is the same gate that test_pinned_memory_resource_rejects_unsupported_host_pool uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda.coreEverything related to the cuda.core moduletestImprovements or additions to teststo-be-backportedTrigger the bot to raise a backport PR upon merge
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to fix internal bug 7080276.
The HOST graph allocation reconstruction test fails on CUDA 12.9 drivers with CUDA_ERROR_INVALID_VALUE: generic HOST pool properties are rejected before the graph-specific support check.
The fix is to skip this test when the runtime CUDA driver version is below 13.0. Keep the existing CUDA_ERROR_NOT_SUPPORTED handling and reconstruction assertions for newer drivers.