Repository navigation
[no-ci] CI: verify the Authenticode signature of vc_redist.x64.exe (13.4.x backport) - #3444
Merged
juenglin merged 2 commits intoNov 12, 2026
Merged
Conversation
The nightly PyTorch rows in test-wheel-windows.yml downloaded and silently ran vc_redist.x64.exe without checking its signature or the installer's exit code. Require a valid Microsoft Authenticode signature before running it, fail on installer errors (allowing 1638 and 3010), and download into RUNNER_TEMP. This matches the existing vc_redist.arm64.exe check. Refs NVIDIA#3195
Contributor
juenglin
changed the title
Contributor
Author
|
/ok to test 6701c82 |
The substring check on SignerCertificate.Subject also accepted an organization such as "Microsoft Corporation Services Ltd" or a CN that embeds "O=Microsoft Corporation". Compare the parsed organization attribute (OID 2.5.4.10) instead, and check the signature status first so an unsigned file gets a clear error. Refs NVIDIA#3195
Contributor
Author
|
/ok to test 4082211 |
jpascucci-nv
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3443 to
13.4.x. Refs #3195.The nightly PyTorch rows in
test-wheel-windows.ymldownloadvc_redist.x64.exefromaka.msand run it silently with admin rights, without checking its signature.Start-Process -Waitwithout-PassThrualso ignored the installer's exit code, so a failed install went unnoticed until PyTorch failed to import.This PR:
ValidAuthenticode signature fromO=Microsoft Corporationbefore running the installer.Get-AuthenticodeSignatureonly reportsValidafter Windows builds the chain to a trusted root, so a tampered or redirected download fails the step.RUNNER_TEMPinstead of the workspace.Validation
pre-commit (including actionlint) passes. This step only runs in
ci-nightly.yml(test-mode: nightly-pytorch), so PR CI does not exercise it; the next nightly run will.Checklist