Repository navigation
ci: enable the Pulse vulnerability and malware scans in the Security … #3239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gmanal
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
gmanal:test/vuln-malware-onboarding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1bd3b7d
ci: enable the Pulse vulnerability and malware scans in the Security …
gmanal 3fed528
Merge branch 'main' into test/vuln-malware-onboarding
gmanal aff64b7
ci: name all Security Suite scans and limit Charon scans to authorize…
gmanal e359e0d
ci: add the GuardWords pre-commit hook
gmanal 8cd8c77
ci: pin security-workflows to v0.6.0
gmanal d9e7f64
Merge remote-tracking branch 'upstream/main' into test/vuln-malware-o…
gmanal 3051986
ci: pass a computed workplan to build-wheel.yml for the vulnerability…
gmanal 730f605
ci: trim Security Suite docs to what contributors act on
gmanal e1a6bdb
Merge remote-tracking branch 'upstream/main' into test/vuln-malware-o…
gmanal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems more complex than necessary. What is the reason to build a wheel here, instead of just adding a job in ci.yml that waits for a wheel build to finish and then download it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The said job can invoke this workflow, and everything you do below can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion, and I did try it — ci.yml calling this workflow after
build-linux-64, keeping everything below line 88. The wiring is fine; the
wheels aren't.
ci.yml's matrix is sharded, so no single run has a complete set for one
interpreter. A recent
mainrun had bindings for 3.12/cu12.9.1 and for3.14t + 3.15t/cu13.5.0, and core for 3.15 — so 3.12 has bindings but no core,
3.15 the reverse.
cuda-*also matches 38 artifacts there, including win-64and aarch64, so
pip downloadfails on the first incompatible wheel.Pulse installs offline and needs one coherent set: one interpreter, one CUDA
major, all runtime deps. Reusing ci.yml's wheels would mean forcing it to
always build a complete 3.12 set — the same work, moved onto everyone's
critical path.