Skip to content

Fix CI failure related to bug in MXFP8 copy implementation - #2369

Merged
vthumbe1503 merged 5 commits into
NVIDIA:mainfrom
vthumbe1503:fix_ci_error
Nov 12, 2025
Merged

vthumbe1503 merged 5 commits into
NVIDIA:mainfrom
vthumbe1503:fix_ci_error

Conversation

@vthumbe1503

@vthumbe1503 vthumbe1503 commented Nov 11, 2025 •

Copy link
Copy Markdown
Collaborator

Description

This PR introduced a bug during the last few commits where in, implementation of copy_ method in torch dispatch accessed mxfp8 attributes without checking if the both source and estination tensors are indeed mxfp8.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Fix MXFP8 tensor's copy method.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants