[https://nvbugs/6537081][fix] Fix import error by 2ez4bz · Pull Request #17112 · NVIDIA/TensorRT-LLM

2ez4bz · 2026-07-31T07:04:18Z

Dev Engineer Review

Updated tensorrt_llm/llmapi/__init__.py.
Added DeepSeekV4SparseAttentionConfig to the public LLM argument configuration imports.
Exported MultimodalConfig through tensorrt_llm.llmapi.
These changes address the reported import error and align the public API exports with the available configuration classes.
No performance or error-handling changes were introduced.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>

2ez4bz · 2026-07-31T07:05:26Z

/bot run

tensorrt-cicd · 2026-07-31T07:10:47Z

PR_Github #62987 [ run ] triggered by Bot. Commit: fdccaa0 Link to invocation

coderabbitai · 2026-07-31T07:15:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2cb94826-5bbd-4b5d-90bb-4dcbff7dbb54

📥 Commits

Reviewing files that changed from the base of the PR and between b118fc3 and fdccaa0.

📒 Files selected for processing (1)

tensorrt_llm/llmapi/__init__.py

Walkthrough

The LLM API module now imports DeepSeekV4SparseAttentionConfig and publicly exports MultimodalConfig.

Changes

LLM API exports

Layer / File(s)	Summary
Update public configuration exports `tensorrt_llm/llmapi/__init__.py`	The module imports `DeepSeekV4SparseAttentionConfig` and adds `MultimodalConfig` to `__all__`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bowenfu, allisonlim-nv, zhaoyangwang-nvidia

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the template and checklist, but the Description and Test Coverage sections are empty.	Add a concise explanation of the issue and solution, and list the relevant tests or explain why no tests are required.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the import error and follows the required NVBugs and fix format.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-07-31T11:20:30Z

PR_Github #62987 [ run ] completed with state SUCCESS. Commit: fdccaa0
/LLM/main/L0_MergeRequest_PR pipeline #51094 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

2ez4bz · 2026-07-31T15:56:47Z

/bot run

tensorrt-cicd · 2026-07-31T16:03:06Z

PR_Github #63060 [ run ] triggered by Bot. Commit: fdccaa0 Link to invocation

tensorrt-cicd · 2026-07-31T17:46:13Z

PR_Github #63060 [ run ] completed with state SUCCESS. Commit: fdccaa0
/LLM/main/L0_MergeRequest_PR pipeline #51159 completed with status: 'SUCCESS'

CI Report

Link to invocation

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>

…ate the CI gate (#2090) ### What does this PR do? Type of change: CI/CD improvement Follow-up to #2086, which carried the speculative-decoding fix; this PR is the CI half. **Lanes now run only when their own files change.** A one-line edit to any example started all 12 example lanes, and any `modelopt/**` change started every GPU suite. - Each lane gates itself inside `_example_tests_runner.yml` / `_gpu_tests_runner.yml`, deriving its watch list from the example or suite name it was already given (`examples/<name>/**`, `tests/examples/<name>/**`, `tests/<suite>/**`). **Adding a new example stays a one-line matrix entry** — no central mapping to update. - The five cross-example dependencies are declared as `watch_extra` next to the example that needs them: `hf_ptq` → `llm_eval` (`huggingface_example.sh` runs lm_eval from `../llm_eval`), `torch_trt` → `onnx_ptq`, `speculative_decoding` → `hf_ptq` + `dataset`, `llm_qat` / `gpt-oss` → `dataset`. - `gpu_tests.yml` is split into caller + runner to match. This shape is forced, not stylistic: job-level `if:` cannot read `matrix`, and `container:` images are pulled before any step runs, so gating inside the job would still pull 10–20 GB and hold a GPU runner for every skipped suite. - `modelopt/**`, `modelopt_recipes/**`, `pyproject.toml` and `tests/_test_utils/**` still run every lane. The gate now watches the last two, which example tests depend on but it previously ignored. **Docs-only changes no longer start GPU jobs.** The gate ignores `**.md`, `**.rst`, `**.png` and `**.ipynb` by default, so a README edit short-circuits the whole workflow. Nothing executes notebooks (no `nbmake`/`nbval` in the repo), and `.sh`/`.yaml`/`.txt` stay watched since examples run them. **One file holds the gate logic.** `.github/actions/changed-files-gate` is a composite action doing the merge-base + changed-files comparison and, optionally, the `^linux$` wait. `_pr_gate.yml` and `_wait_for_checks.yml` are both deleted: each top-level workflow keeps a 12-line `pr-gate` job that is pure wiring, and the runners use the action as steps so a lane shows `gate` + `run-test` rather than three checks. Calling a reusable workflow always materializes all of its jobs, including skipped ones, which is what made the per-lane check list noisy. `unit_tests.yml` also drops its DCO wait: DCO can be marked passing manually, so blocking the matrix on it only delayed feedback. The `^linux$` wait remains, which is the gate that actually protects GPU runners. **Also, from the original lane consolidation:** - **One TensorRT-LLM lane.** `trtllm-pr` and `trtllm-non-pr` merge into a single `trtllm` job gated like the others, so `llm_eval` now runs on PRs, where it was nightly-only. - **`gpt-oss` moves to the TensorRT-LLM image.** Its deploy step needs `tensorrt_llm`, which `pytorch` doesn't have, so `deploy_gpt_oss_trtllm` silently skipped in CI. Its `importorskip` is dropped now that the lane guarantees the dependency. - **Containers bumped where no reason was documented:** pytorch `26.06`/`26.01` → `26.07` (torch example lane, regression). Left pinned with their existing in-file reasons: pytorch `26.05` for the gpu lane (`EXPLICIT_BATCH` removed in TensorRT 11), tensorrt `26.05` for the onnx lane (`torch-tensorrt` needs `libnvinfer.so.10`), vllm `v0.20.0` (legacy FusedMoE coverage). TensorRT-LLM stays on `1.3.0rc20`: rc21–rc23 ship a `quickstart_multimodal.py` importing `MultimodalConfig` before `tensorrt_llm.llmapi` exported it (fixed upstream in NVIDIA/TensorRT-LLM#17112, one day after rc23 was cut), which fails the `hf_ptq` VLM deploy smoke test. Also clarifies the changelog line in the PR template to spell out when an entry is expected. **Two silent-failure fixes found in review:** - Every gate used `any_changed`, which is ACMR and excludes deletions, so a delete-only PR (removing an example, a test, or library code) ran nothing. Now `any_modified` (ACMRD), fixed in `example_tests.yml`, `_pr_gate.yml` and `unit_tests.yml`. - `git merge-base` was piped into `tee`, so a failure returned `tee`'s exit status and emitted an empty base, quietly changing which lanes run instead of failing. **Nightly secret scanning is fixed.** `code_quality.yml` excludes trufflehog's `lob` detector: its `(live|test)_[a-zA-Z0-9_]{35}` pattern matches any pytest function whose name is exactly 35 characters after `test_` — 60 of them in this repo, e.g. `test_all_zero_activation_yields_no_scale` — and reports them as *verified* secrets. This only ever failed nightly because the action scans all history on `schedule` and only the PR diff on `pull_request`. ### Testing Workflow YAML validated locally and the selection logic checked by hand across scenarios (`examples/diffusers/**` → onnx lane only; `examples/dataset/**` → `llm_qat`, `speculative_decoding`, `gpt-oss`; `examples/llm_eval/**` → `hf_ptq` + `llm_eval`; `modelopt/**` and nightly → everything). Gating behavior itself can only be exercised by a real PR run — the failure mode to watch for is a lane skipping when it should have run. ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A — CI configuration - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A - Did you get Claude approval on this PR?: ❌ — not yet run  ## Summary by CodeRabbit - **CI Improvements** - Improved change detection for model recipes, test utilities, workflow actions, and documentation-only updates. - Streamlined pull request checks and status monitoring. - Consolidated TensorRT-LLM example validation and refined conditional test execution. - Updated test environments to newer PyTorch releases. - Refined GPU, regression, and unit test triggers. - Deployment tests no longer automatically skip when TensorRT-LLM is unavailable. - Updated secret scanning configuration. - **Documentation** - Updated pull request checklist guidance to include deprecations and critical bug fixes.  Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

[https://nvbugs/6537081][fix] Fix import error

fdccaa0

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>

2ez4bz requested a review from a team as a code owner July 31, 2026 07:04

2ez4bz requested review from allisonlim-nv and zhaoyangwang-nvidia July 31, 2026 07:04

github-actions Bot assigned 2ez4bz Jul 31, 2026

2ez4bz enabled auto-merge (squash) July 31, 2026 07:05

Wanli-Jiang approved these changes Jul 31, 2026

View reviewed changes

zhaoyangwang-nvidia approved these changes Jul 31, 2026

View reviewed changes

lori-ren approved these changes Jul 31, 2026

View reviewed changes

2ez4bz merged commit e34d3d4 into NVIDIA:main Jul 31, 2026
13 checks passed

yuanjingx87 pushed a commit that referenced this pull request Aug 1, 2026

[https://nvbugs/6537081][fix] Fix import error (#17112)

62152b8

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>

This was referenced Aug 6, 2026

Fix EAGLE-3 context-parallel training and re-enable its tests NVIDIA/Model-Optimizer#2086

Merged

Gate example and GPU test lanes on the files they cover, and consolidate the CI gate NVIDIA/Model-Optimizer#2090

Merged

Navigation Menu

Repository navigation

[https://nvbugs/6537081][fix] Fix import error - #17112

[https://nvbugs/6537081][fix] Fix import error#17112
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nvbug-6537081

2ez4bz commented Jul 31, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

2ez4bz commented Jul 31, 2026

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

coderabbitai Bot commented Jul 31, 2026

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

2ez4bz commented Jul 31, 2026

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

2ez4bz commented Jul 31, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dev Engineer Review

QA Engineer Review

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

2ez4bz commented Jul 31, 2026

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

coderabbitai Bot commented Jul 31, 2026

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

2ez4bz commented Jul 31, 2026

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

tensorrt-cicd commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

2ez4bz commented Jul 31, 2026 •

edited by coderabbitai Bot

Loading