Repository navigation
fix(ingest): inspect unverified OMS bundle contents - #795
Open
yashrajp22 wants to merge 3 commits into
Open
yashrajp22 wants to merge 3 commits into
yashrajp22 wants to merge 3 commits into
Conversation
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A skill could forge the shape of an OMS signature bundle and have the whole file excluded from analysis. Recognized bundles now stay in the raw, local, and provider-eligible inputs and follow normal component analysis. Encoded payload interpretation is explicitly marked partial, so an unverified bundle cannot produce a complete/SAFE result.
This change does not validate signatures or claim decoded-payload coverage. Existing base64 detection can now flag genuine OMS bundles too; their shape no longer grants a security exemption. In the sample corpus, those added signals move one previously CAUTION result to DO_NOT_INSTALL. This conservative behavior needs review before merging.
Validation: 728 related tests and Ruff checks passed. Source and a fresh installed wheel matched on forged-wrapper, encoded-only, and real-bundle samples. Both forged-bundle regressions fail with the original ingestion code. All 12 pinned corpus samples matched between source and wheel: five stayed unchanged, while seven OMS-bearing samples gained existing SC3 signals and partial coverage; no earlier findings disappeared. These runs were offline and did not contact an LLM provider.