Skip to content

fix(server): bind gateway listeners before sandbox resume - #2495

Merged
drew merged 2 commits into
mainfrom
codex/gateway-bind-before-resume
Jul 27, 2026
Merged

fix(server): bind gateway listeners before sandbox resume#2495
drew merged 2 commits into
mainfrom
codex/gateway-bind-before-resume

Conversation

@elezar

@elezar elezar commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

Bind all resolved gateway listener sockets before resuming persisted sandboxes. This prevents a startup bind failure from occurring after sandbox compute has already been resumed, while preserving the invariant that resume completes before compute watchers start.

Related Issue

No linked issue.

Changes

  • Extract gateway listener address resolution and socket binding into a focused helper
  • Bind the primary and driver-provided gateway listeners before persisted sandbox resume
  • Keep watcher startup after resume so watchers observe post-resume state
  • Add a regression test proving a failed extra-listener bind prevents the resume path from being reached

Testing

  • mise run pre-commit passes
  • Unit tests added/updated (cargo test -p openshell-server gateway_listener)
  • E2E tests added/updated (not applicable; startup ordering is covered by the regression unit test)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; no stable documented interface changed)

elezar added 2 commits July 27, 2026 15:34
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@drew
drew added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 39bf94e Jul 27, 2026
30 checks passed
@drew
drew deleted the codex/gateway-bind-before-resume branch July 27, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants