Fix partial storage transfer success

[ecolternv]

Description

Make OSMO upload/download explicitly fail when not all files are successfully uploaded/downloaded

Issue - None

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

Summary by CodeRabbit

• Bug Fixes

  • Upload and download commands now report an error when one or more files fail to transfer.
  • Error messages include details for every failed file, making transfer issues easier to identify.

• Tests

  • Added coverage for upload and download operations with multiple failed files.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d9196e4a-a331-4167-b128-99241665bb11

📥 Commits

Reviewing files that changed from the base of the PR and between 59f9300 and 4c6468f.

📒 Files selected for processing (2)

• src/cli/data.py
• src/cli/tests/test_cli.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

Upload and download commands now capture transfer summaries and raise OSMODataStorageError when failures exist. Tests verify that errors include all failed-file messages for both commands.

Changes

Data transfer failure reporting

Layer / File(s)	Summary
Transfer error handling and validation src/cli/data.py, src/cli/tests/test_cli.py	Upload and download commands raise OSMODataStorageError when transfer summaries contain failures. Tests verify that every failed-file message appears in the raised error.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: ethany-nv, fernandol-nvidia

Merge Risk: ⚪ Minimal · up to 4c646

Failed transfers are now reported as command errors with failed-file details, with no concrete unresolved merge risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: preventing partial storage transfers from being treated as successful.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ecolter/debug-storage-failures

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.47%. Comparing base (59f9300) to head (4c6468f).

Files with missing lines	Patch %	Lines
src/cli/data.py	66.66%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
+ Coverage   76.14%   76.47%   +0.33%     
==========================================
  Files         246      247       +1     
  Lines       29864    29884      +20     
  Branches     4494     4500       +6     
==========================================
+ Hits        22740    22854     +114     
+ Misses       6221     6133      -88     
+ Partials      903      897       -6     

Flag	Coverage Δ
backend	79.47% <66.66%> (+0.35%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/cli/data.py	53.91% <66.66%> (+3.46%)	⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.