Repository navigation
Conversation
…e reached EagleVllmStreamingDataset reads a sample's hidden states over RDMA, then asks the vLLM sidecar's /done whether the slot's ring lapped the read (stale bytes). When that call failed, the read was assumed valid, so a sidecar outage could feed overwritten hidden states into training without a warning. A failed /done cannot prove the bytes are the sample's, and a resample is cheap, so the read is now discarded as a miss: it warns and counts against the existing consecutive-failure circuit breaker. Only transport failures count as a miss, per the module's own _TRANSIENT_FETCH_ERRORS (httpx.HTTPError, OSError), with raise_for_status() so a non-2xx answer is one too. A 200 without `valid` breaks the sidecar contract and raises, as other contract violations in _fetch do, rather than turning every sample into a miss until the breaker blames the server. Split out of #2279. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No identified issue currently blocks merging; run the normal checks before merging. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 72.73% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (5 passed)
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: fail-closed handling when the streaming /donecheck is unreachable.Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Security Anti-Patterns PASS. The pull request changes only /doneerror handling and adds tests. The added Python lines contain notorch.load(..., weights_only=False),numpy.load(..., allow_pickle=True), hardcoded `tru…
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
h-guo18
added a commit
that referenced
this pull request
Oct 12, 2026
Failing closed on an unreachable /done is a correctness fix unrelated to training speed, so it gets its own PR, #2756, which also narrows the except to the module's transient errors. This restores hf_streaming_dataset.py and its test to main's. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
+ Coverage 69.47% 78.26% +8.78%
==========================================
Files 646 646
Lines 71672 71675 +3
==========================================
+ Hits 49796 56093 +6297
+ Misses 21876 15582 -6294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
EagleVllmStreamingDataset(the RDMA streaming path) reads a sample's hidden states, then asks the vLLM sidecar's/donewhether the slot's ring lapped the read. When that call failed, the read was assumed valid, so a sidecar outage could feed overwritten hidden states into training without a warning./donenow discards the read as a miss: it warns, resamples, and counts against the existing consecutive-failure circuit breaker (fail_after_consecutive_skips)._TRANSIENT_FETCH_ERRORS(httpx.HTTPError,OSError);raise_for_status()makes a non-2xx answer one of them. A 200 withoutvalidis a sidecar contract break and raises, like the other contract violations in_fetch.Usage
No API change.
Testing
tests/unit/torch/speculative/plugins/test_hf_streaming_dataset.py: 21 passed. New tests:/doneresamples and returns the next sample;valid: true;validraisesKeyError. This one fails if theexceptis widened back toException.Before your PR is "Ready for review"
CONTRIBUTING.md: N/AAdditional Information
Split out of #2279, which is about training speed.
🤖 Generated with Claude Code
Summary by CodeRabbit