Skip to content

Move Nemotron Nano offline KD example - #2471

Merged
kevalmorabia97 merged 1 commit into
mainfrom
codex/move-nemotron-nano-offline-kd-example
Sep 18, 2026
Merged

kevalmorabia97 merged 1 commit into
mainfrom
codex/move-nemotron-nano-offline-kd-example

Conversation

@jenchen13

@jenchen13 jenchen13 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change: Bug fix

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅ / ❌ / N/A
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: ✅ / ❌ / N/A
  • Did you write any new necessary tests?: ✅ / ❌ / N/A
  • Did you update Changelog?: ✅ / ❌ / N/A
  • Did you get Claude approval on this PR?: ✅ / ❌ / N/A

Additional Information

Summary by CodeRabbit

  • Documentation
    • Updated the NVIDIA Nemotron offline usage example to use the BF16 source-directory pipeline path.
    • Pipeline configuration remains unchanged.

Signed-off-by: Jennifer Chen <jennifchen@nvidia.com>
@jenchen13
jenchen13 requested a review from a team as a code owner September 18, 2026 16:49
@jenchen13
jenchen13 requested a review from AAnoosheh September 18, 2026 16:49
@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8b1a630b-3e07-48d9-9688-98a35b939b19

📥 Commits

Reviewing files that changed from the base of the PR and between 17ef5b6 and c777227.

📒 Files selected for processing (1)
  • tools/launcher/examples/nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16/offline_kd_qad.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The documented launcher command now references the BF16 source-directory pipeline configuration. No pipeline configuration values changed.

Changes

Launcher example

Layer / File(s) Summary
BF16 launcher path update
tools/launcher/examples/nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16/offline_kd_qad.yaml
The documented command now references the BF16 configuration path instead of the NVFP4 path.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: aanoosheh

Merge Risk: ⚪ Minimal · up to c7772

This documentation-only path correction is ready to merge.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: moving the Nemotron Nano offline KD example.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed PASS. The authoritative PR range changes one YAML example by renaming its directory and updating the usage path. It contains no Python changes, dependency changes, or added security-sensitive patterns…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.91%. Comparing base (17ef5b6) to head (c777227).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2471   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files         600      600           
  Lines       65981    65981           
=======================================
  Hits        46788    46788           
  Misses      19193    19193           
Flag Coverage Δ
regression 15.22% <ø> (+0.05%) ⬆️
unit 58.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit c4d00f7 into main Sep 18, 2026
44 checks passed
@kevalmorabia97
kevalmorabia97 deleted the codex/move-nemotron-nano-offline-kd-example branch September 18, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-18 18:43 UTC

@chadvoegele chadvoegele added the cherry-pick-done Added by bot once PR is cherry-picked to the release branch label Sep 22, 2026
chadvoegele pushed a commit that referenced this pull request Sep 22, 2026
### What does this PR do?

Type of change: Bug fix

<!-- Details about the change. -->

### Usage

```python
# Add a code snippet demonstrating how to use this
```

### Testing
<!-- Mention how have you tested your change if applicable. -->

### Before your PR is "*Ready for review*"

Make sure you read and follow [Contributor
guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md)
and your commits are signed (`git commit -s -S`).

Make sure you read and follow the [Security Best
Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-practices-for-contributors)
(e.g. avoiding hardcoded `trust_remote_code=True`, `torch.load(...,
weights_only=False)`, `pickle`, etc.).

- Is this change backward compatible?: ✅ / ❌ / N/A <!--- If ❌, explain
why. -->
- If you copied code from any other sources or added a new PIP
dependency, did you follow guidance in `CONTRIBUTING.md`: ✅ / ❌ / N/A
<!--- Mandatory -->
- Did you write any new necessary tests?: ✅ / ❌ / N/A <!--- Mandatory
for new features or examples. -->
- Did you update
[Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?:
✅ / ❌ / N/A <!--- Very short summary of changes only for new features,
backward breaking changes, deprecations, or fixes for critical bugs
present in previous releases. -->
- Did you get Claude approval on this PR?: ✅ / ❌ / N/A <!--- Run
`/claude review`. NVIDIA org members can self-trigger for complex
changes; orthogonal to CodeRabbit. -->

### Additional Information
<!-- E.g. related issue. -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated the NVIDIA Nemotron offline usage example to use the BF16
source-directory pipeline path.
  * Pipeline configuration remains unchanged.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jennifer Chen <jennifchen@nvidia.com>
Signed-off-by: Chad Voegele <cvoegele@nvidia.com>
@chadvoegele chadvoegele removed cherry-pick-done Added by bot once PR is cherry-picked to the release branch cherry-pick-0.47.0 labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants