Repository navigation
docs(tools/mcp): scope policy — environment tooling, not workflow policy - #1712
Conversation
… policy The 14 tools across modelopt-mcp, nmm-sandbox-mcp, and pensieve-intern-mcp are deliberately verb-shaped primitives on the cluster, launcher, and agent engine. They are universal across workflows — environment tooling, not workflow policy. Adding workflow-specific tools (e.g., bench_eagle3_against_baseline, create_specdec_release_pr) would sprawl the catalog, force per-workflow opt-in, and break the 'pre-knowledge' promise that makes MCP-as-baseline valuable for pensieve-intern's intern-agents. SCOPE.md documents the test, the failure modes to watch for, the side-by-side in-scope/out-of-scope examples, and practical guidance for evaluating new tools. The policy applies to all three servers in the MCP family. Anchor: OMNIML-5123 follow-up discussion (2026-06-13). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Chenhan Yu <chenhany@nvidia.com>
📝 WalkthroughWalkthroughAdds a new ChangesMCP Scope Policy Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
=======================================
Coverage 77.12% 77.12%
=======================================
Files 511 511
Lines 56236 56236
=======================================
Hits 43374 43374
Misses 12862 12862
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/claude review |
There was a problem hiding this comment.
Claude review passed — no blocking issues found. LGTM
Docs-only PR adding tools/mcp/SCOPE.md and a short cross-reference in tools/mcp/README.md. Verified:
- Tool inventory in SCOPE.md (9 modelopt-mcp tools) matches the README tool table and the "9 tool definitions" referenced in
modelopt_mcp/server.py. No drift. - README→SCOPE relative link resolves.
- No code, schema, API, algorithm, mode/state, export, or compatibility surface touched. Coverage unchanged at 77.12%.
The pre-merge security warning CodeRabbit posted (# nosec in bridge.py) refers to pre-existing code on main, not anything introduced by this PR's diff. No findings from this review.
|
Summary
Adds
tools/mcp/SCOPE.mddocumenting the design boundary for the MCP server family (modelopt-mcp+nmm-sandbox-mcp+pensieve-intern-mcp):Why
Surfaced during the OMNIML-5123 follow-up discussion. The 14 tools currently in scope across the three servers are deliberately a small, closed set. Letting workflow-specific tools sneak in would sprawl the catalog, force per-workflow opt-in, and break the "MCP-as-pre-knowledge" promise that makes the catalog useful as a stable baseline for pensieve-intern's agents.
SCOPE.md documents:
Anchor
OMNIML-5123 (Epic).
Docs-only, no code changes.
Summary by CodeRabbit