Merge template - #12
Merged
Merged
Conversation
Co-authored-by: cheroy-ntia <58193992+cheroy-ntia@users.noreply.github.com>
Fix Windows Py3.9 test collection failure from PEP 604 type unions
Co-authored-by: cheroy-ntia <58193992+cheroy-ntia@users.noreply.github.com>
Fix macOS x64 Python 3.9 CI job runner selection
# Conflicts: # .github/workflows/pytest.yml # .github/workflows/release.yml # pyproject.toml # src/ITS/PropLibTemplate/__init__.py # src/ITS/PropLibTemplate/proplib_template.py # tests/test_utils.py
jodumkeNTIA
approved these changes
Sep 15, 2026
jodumkeNTIA
left a comment
jodumkeNTIA
left a comment
There was a problem hiding this comment.
Good job, changes appear very similar to other similar PRs (commenting out GitHub auto actions(yml files), updating comments, adding library not found checks, updating OS imports, updating OS handing of packages, updating python virtual environment dependencies(pytest/other), ...) Also, just FYI, on windows appears to be using older DLLs (v1.1) instead of newest DLLs v1.2 which is fine.
https://github.com/NTIA/LFMF/releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.