Repository navigation
fix: remove unused Link import - #181
skmdfirdousf34 wants to merge 1 commit into
Conversation
|
@oathteamapp-cloud is attempting to deploy a commit to the Geetansh Goyal's projects Team on Vercel. A member of the Team first needs to authorize it. |
📸 How this looksBuilt from this PR, so you can see the change without checking it out.
|
chanchalagarwal3580
left a comment
There was a problem hiding this comment.
The removal of the unused Link import is clean and directly satisfies Issue #56. I verified locally that running npx eslint components/esoc-record.tsx outputs 0 errors and no no-unused-vars warnings. The only links in this component are external GitHub profile links using standard <a> tags (line 116), so next/link is indeed not needed here.
chanchalagarwal3580
left a comment
There was a problem hiding this comment.
I checked the linked issue (#56) first and reviewed the changed component (components/esoc-record.tsx).
I checked out this PR branch locally (pr-181, commit 835932c) and ran the full suite of checks:
npx eslint components/esoc-record.tsx: Passed (0 errors, 0no-unused-varswarnings).npm run lint: Passed (0 errors, 37 preexisting repo warnings).npm test: Passed (13/13 test files passed, 121/121 unit tests passed).npm run build: Passed (TypeScript passed in 2.5s, all 72 static/dynamic routes compiled cleanly including/esoc).
Question on component design:
I noticed that member GitHub handles are rendered as external links to https://github.com/${member.github}, whereas member names are rendered as plain text. Was Link originally imported with the intention of linking member names/cards to internal student profiles (such as /students/[slug]), or was it just leftover boilerplate from initial component scaffolding?




What
Removed the unused
Linkimport fromcomponents/esoc-record.tsx.Fixes #56
How I tested it
npm run lint— passed (0 errors)npm run build— passedChecklist
npm run lintandnpm run buildpass locally