Skip to content

fix: remove unused Link import - #181

Open
skmdfirdousf34 wants to merge 1 commit into
NST-DEVFORGE:mainfrom
skmdfirdousf34:fix/remove-unused-link
Open

skmdfirdousf34 wants to merge 1 commit into
NST-DEVFORGE:mainfrom
skmdfirdousf34:fix/remove-unused-link

Conversation

@skmdfirdousf34

Copy link
Copy Markdown

What

Removed the unused Link import from components/esoc-record.tsx.

Fixes #56

How I tested it

  • npm run lint — passed (0 errors)
  • npm run build — passed

Checklist

  • I was assigned the issue before I started
  • npm run lint and npm run build pass locally
  • The diff only touches what the issue asked for

@vercel

vercel Bot commented Oct 3, 2026

Copy link
Copy Markdown

@oathteamapp-cloud is attempting to deploy a commit to the Geetansh Goyal's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions Bot added a commit that referenced this pull request Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

📸 How this looks

Built from this PR, so you can see the change without checking it out.

/

Desktop (1280px), top 3000px
Mobile (390px), top 3000px

/learn/open-source

Desktop (1280px), top 3000px
Mobile (390px), top 3000px

Screenshots are taken from a production build of this PR, signed out. Pages behind sign-in show the signed-out view. Build log

@chanchalagarwal3580 chanchalagarwal3580 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the unused Link import is clean and directly satisfies Issue #56. I verified locally that running npx eslint components/esoc-record.tsx outputs 0 errors and no no-unused-vars warnings. The only links in this component are external GitHub profile links using standard <a> tags (line 116), so next/link is indeed not needed here.

@chanchalagarwal3580 chanchalagarwal3580 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the linked issue (#56) first and reviewed the changed component (components/esoc-record.tsx).

I checked out this PR branch locally (pr-181, commit 835932c) and ran the full suite of checks:

  • npx eslint components/esoc-record.tsx: Passed (0 errors, 0 no-unused-vars warnings).
  • npm run lint: Passed (0 errors, 37 preexisting repo warnings).
  • npm test: Passed (13/13 test files passed, 121/121 unit tests passed).
  • npm run build: Passed (TypeScript passed in 2.5s, all 72 static/dynamic routes compiled cleanly including /esoc).

Question on component design:

I noticed that member GitHub handles are rendered as external links to https://github.com/${member.github}, whereas member names are rendered as plain text. Was Link originally imported with the intention of linking member names/cards to internal student profiles (such as /students/[slug]), or was it just leftover boilerplate from initial component scaffolding?

Comment thread components/esoc-record.tsx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused Link import in esoc-record.tsx

3 participants