Skip to content

Add Desc to Packages & Fix Workflows - #573

Open
AkshatRai07 wants to merge 3 commits into
masterfrom
scarlehoff-patch-1
Open

Add Desc to Packages & Fix Workflows#573
AkshatRai07 wants to merge 3 commits into
masterfrom
scarlehoff-patch-1

Conversation

@AkshatRai07

@AkshatRai07 AkshatRai07 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Closes #571
Closes #572
Closes #574

In this PR we:

  • Add description to eko-rs and ekore-rs
  • Bypass poetry dynamic versioning in release-python.yml
  • Update actions' versions

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:14
@AkshatRai07 AkshatRai07 changed the title Fix Workflows Add Desc to Packages & Fix Workflows Sep 11, 2026
@AkshatRai07

Copy link
Copy Markdown
Collaborator Author

I was about to push these 3 commits but then noticed #569 was already merged. Anyways, these are the fixes to the remaining issues.

@felixhekhorn

Copy link
Copy Markdown
Collaborator

I was about to push these 3 commits but then noticed #569 was already merged. Anyways, these are the fixes to the remaining issues.

I wasn't sure about your schedule so I just split the remaining issues into issues 🙃

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Python release workflow has unresolved injection and non-tag publishing risks.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates package metadata and CI/CD workflows for Python and Rust releases.

Changes:

  • Adds README metadata to eko-rs and ekore-rs.
  • Updates GitHub Actions versions.
  • Adds Poetry release-version handling and skip-existing publishing.
File summaries
File Summary
crates/ekore_py/pyproject.toml Adds README metadata.
crates/eko/pyproject.toml Adds README metadata.
.github/workflows/unittests-rust.yml Updates test actions.
.github/workflows/unittests-pyapi.yml Updates Python test actions.
.github/workflows/unittests-capi.yml Updates C-API test actions.
.github/workflows/release-python.yml Critical (3 votes): Manual tag input risks shell/GITHUB_ENV injection. Moderate (1 vote): Dispatch accepts non-tag refs; checkout should require refs/tags/<tag>.
.github/workflows/release-pyapi.yml Updates release actions.
.github/workflows/release-ekors.yml Updates release actions.
.github/workflows/release-crates.yml Updates release actions.
.github/workflows/release-capi.yml Updates release actions.
.github/workflows/python-poetry-tests-with-data.yml Updates test actions.
.github/workflows/msrv.yml Updates checkout action.
.github/workflows/bench-lha.yml Updates benchmark actions.
.github/workflows/bench-lha-rust.yml Updates Rust benchmark actions.
.github/workflows/bench-iso.yml Updates benchmark actions.
Review details

Suppressed comments (1)

.github/workflows/release-python.yml:31

  • For workflow_dispatch, this expression accepts any ref name, including a branch or commit, even though the input is documented as an existing release tag. That can publish non-release code with a release version; force the checkout to refs/tags/<tag> (and let checkout fail when the tag does not exist).
          ref: ${{ github.event.inputs.tag || github.ref }}
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +35 to +39
run: |
TAG="${{ github.event.inputs.tag || github.ref_name }}"
# Strip leading 'v' if present
VERSION="${TAG#v}"
echo "POETRY_DYNAMIC_VERSIONING_BYPASS=${VERSION}" >> $GITHUB_ENV
@felixhekhorn felixhekhorn added benchmarks Benchmark (or infrastructure) related rust Rust extension related labels Sep 11, 2026
@felixhekhorn

Copy link
Copy Markdown
Collaborator

Oi, https://github.com/NNPDF/eko/actions/runs/34597898865/job/103257862589?pr=573 is a side-effect of #570 (yes, yes I know the patching is not the best idea ever 🙈 ) - can you please fix it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Benchmark (or infrastructure) related rust Rust extension related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redo tags in workflows Improve GitHub workflows Fix description of Rust packages on PyPI

3 participants