Add Desc to Packages & Fix Workflows - #573
Conversation
|
I was about to push these 3 commits but then noticed #569 was already merged. Anyways, these are the fixes to the remaining issues. |
I wasn't sure about your schedule so I just split the remaining issues into issues 🙃 |
There was a problem hiding this comment.
🟡 Changes recommended
The Python release workflow has unresolved injection and non-tag publishing risks.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates package metadata and CI/CD workflows for Python and Rust releases.
Changes:
- Adds README metadata to
eko-rsandekore-rs. - Updates GitHub Actions versions.
- Adds Poetry release-version handling and skip-existing publishing.
File summaries
| File | Summary |
|---|---|
crates/ekore_py/pyproject.toml |
Adds README metadata. |
crates/eko/pyproject.toml |
Adds README metadata. |
.github/workflows/unittests-rust.yml |
Updates test actions. |
.github/workflows/unittests-pyapi.yml |
Updates Python test actions. |
.github/workflows/unittests-capi.yml |
Updates C-API test actions. |
.github/workflows/release-python.yml |
Critical (3 votes): Manual tag input risks shell/GITHUB_ENV injection. Moderate (1 vote): Dispatch accepts non-tag refs; checkout should require refs/tags/<tag>. |
.github/workflows/release-pyapi.yml |
Updates release actions. |
.github/workflows/release-ekors.yml |
Updates release actions. |
.github/workflows/release-crates.yml |
Updates release actions. |
.github/workflows/release-capi.yml |
Updates release actions. |
.github/workflows/python-poetry-tests-with-data.yml |
Updates test actions. |
.github/workflows/msrv.yml |
Updates checkout action. |
.github/workflows/bench-lha.yml |
Updates benchmark actions. |
.github/workflows/bench-lha-rust.yml |
Updates Rust benchmark actions. |
.github/workflows/bench-iso.yml |
Updates benchmark actions. |
Review details
Suppressed comments (1)
.github/workflows/release-python.yml:31
- For
workflow_dispatch, this expression accepts any ref name, including a branch or commit, even though the input is documented as an existing release tag. That can publish non-release code with a release version; force the checkout torefs/tags/<tag>(and let checkout fail when the tag does not exist).
ref: ${{ github.event.inputs.tag || github.ref }}
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| run: | | ||
| TAG="${{ github.event.inputs.tag || github.ref_name }}" | ||
| # Strip leading 'v' if present | ||
| VERSION="${TAG#v}" | ||
| echo "POETRY_DYNAMIC_VERSIONING_BYPASS=${VERSION}" >> $GITHUB_ENV |
|
Oi, https://github.com/NNPDF/eko/actions/runs/34597898865/job/103257862589?pr=573 is a side-effect of #570 (yes, yes I know the patching is not the best idea ever 🙈 ) - can you please fix it here? |
Closes #571
Closes #572
Closes #574
In this PR we:
eko-rsandekore-rsrelease-python.yml