Skip to content

Removed apidocs choice from cookiecutter step - #194

Merged
eriktks merged 1 commit into
mainfrom
176-apidoc-selection
Apr 21, 2021
Merged

eriktks merged 1 commit into
mainfrom
176-apidoc-selection

Conversation

@eriktks

@eriktks eriktks commented Apr 20, 2021 •

Copy link
Copy Markdown
Member

Refs: #176

Description

Removed the choice of apidocs (yes or no) from the cookiecutter setup. Also removed all references to the cookiecutter apidocs flag variable. Thereby made apidocs a standard feature of the generated repository.

To test

  1. check out this PR
  2. got to parent directory cd ..
  3. Run cookiecutter with on the local python-template repository: cookiecutter python-template

Next, verify that cookiecutter does not ask about apidocs and that the docs/confs.py file of the generated package contains code related to apidocs

@eriktks
eriktks marked this pull request as ready for review April 20, 2021 13:20

@jspaaks jspaaks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdiblen fdiblen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @eriktks. Thanks a lot! 💂

@eriktks
eriktks merged commit b69ce98 into main Apr 21, 2021
@eriktks

eriktks commented Apr 21, 2021

Copy link
Copy Markdown
Member Author

Ok, thanks!

@eriktks
eriktks deleted the 176-apidoc-selection branch April 21, 2021 09:03
@eriktks eriktks mentioned this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants