Repository navigation
wrong links that point towards the github page of the new package #355
Description
the template generates the wrong links for links that point towards pages inside the generated package. ie, instead of https://github.com/my-new-package/somepage, links are git@github.com:my-new-package/somepage.
See examples and fixes here:
ivory-tower-private-power/sirup@78249e2
ivory-tower-private-power/sirup@f345568
Activity
[-]wrong links to generated package[/-][+]wrong links that point towards the github page of the new package[/+]egpbos commentedon Oct 16, 2023
Isn't that the SSH-based remote URL? Like this one:
f-hafner commentedon Oct 17, 2023
yes, you're right, but I was not concise enough, sorry. I meant the links that point towards a website that are openend in a browser. For instance, the markdown link checker does not find this
git@github.com:ivory-tower-private-power/sirup/issues, but only thishttps://github.com/ivory-tower-private-power/sirup/issues. I think some links in README.dev.md, CONTRIBUTING.md, and next_steps.md are affected.egpbos commentedon Oct 17, 2023
Ah ok, that's an issue indeed...
sjvrijn commentedon Oct 17, 2023
Pip complained about this too when installing via pyproject.toml, so #352 includes a new
repository_urlcookiecutter variable for these cases.egpbos commentedon Oct 17, 2023
@sjvrijn does that solve this whole issue?
sjvrijn commentedon Oct 17, 2023
@egpbos It will 🙂
egpbos commentedon Dec 18, 2023
Since #352 was merged this should be fixed now. Please reopen if this is still an issue.