Repository navigation
update on publishing through pypi - #323
Merged
Merged
Conversation
bouweandela
requested changes
Jan 17, 2024
bouweandela
left a comment
Member
There was a problem hiding this comment.
Thanks for the update! ✨ I would suggest reducing the amount of text a bit because that will make it easier to maintain: maybe remove the links to examples and the extensive explanation of how to use test pypi (link to an external resource describing this workflow instead)?
Updating the python-template so it follows what is described in the guide would be nice.
Co-authored-by: Bouwe Andela <bouweandela@gmail.com>
Contributor
Author
|
I shortened as suggested, what do you think? To update the template, I will make an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose a fix to #290:
Notes
Questions