Allow state overview on non-OK states

[MisterMountain]

Right now - unless i am doing something wrong - its not possible for me to have that state overview

[OK] - states: ok=2
\_ [OK] System Board 1 Ambient Temp --- 0.7.1.14 is 20°C
\_ [OK] System Board 1 Test Temp is 250°C
|temp=20C;500;600 temp=250C;500;600

Now, when the overall state is critical because one of the subchecks is critical, the first line shows the worst subchecks result:

[CRITICAL] - System Board 1 Test Temp is 250°C
\_ [OK] System Board 1 Ambient Temp --- 0.7.1.14 is 20°C
\_ [CRITICAL] System Board 1 Test Temp is 250°C
|temp=20C;50;60 temp=250C;50;60

I think its a valid idea to do it like its currently is, but an optional feature to change it to my expected behaviour - showing states: critical=1, ok=1 - would be a good idea.

[RincewindsHat]

This was a design decision, since in some monitoring systems (namely Naemon and Nagios) the first line is often taken as a message for notifications, something pretty common if the message has to be short (e.g. pager and similar).
The state overview was pretty pointless there, since it did not hint to any specific problem which it does now.
I would be open to make this configurable, but I would like to stay with this default if there is no really good argument against it.

[martialblog]

One thing I want to add is, that is might be a bit confusing that the output is sometimes a state summary [OK] - states: ok=2 and sometimes an actual output [CRITICAL] - System Board 1 Test Temp is 250°C. That is what threw our dear colleague here, and tbh also me at first who knows this lib in an out.

[RincewindsHat]

Hm, I see. Could you think of a better solution?

[martialblog]

Just some ideas, nothing concrete:

• Provide different public methods on the Overall, e.g. to get the state counter and users can concat it if needed
• Always output the state counter and then the PartialResult output on the same line