Skip to content

Addition of return_esmpy_regrid_operator to regrids and regridc? #766

Description

@mattjbr123

Hiya,
I've noticed that between v3.13.1 and v3.14.0, when the regridding code was refactored as part of the dask implentation (#438), the behaviour of the return_operator kwarg to regrids and regridc changed. In v3.13.1 the cf.RegridOperator it returned could be used to access the ESMF.Regrid object via the regrid attribute. In v3.14.0 and beyond this is no longer the case, but a return_esmpy_regrid_operator kwarg has been added to the new regrid worker function which allows access to the ESMF.Regrid object. However this is not a kwarg available in regrids and regridc, which call regrid, so I would have to call regrid directly to access the ESMF.Regrid object, which is probably not recommended/ideal etc.

To my relatively untrained eye it looks like there should not be a problem adding the return_esmpy_regrid_operator kwarg to regrids and regridc and passing it to regrid, and am happy to put together a very simple PR to add this in if so, but you might be able to advise better!

More details on the issue this is causing here: unifhy-org/unifhy#98

Activity

  1. davidhassell commented on Apr 24, 2024

    @davidhassell
    Collaborator

    Hi Matt,

    Thanks for this, and sorry that we confounded things for you! I'm sure that we can put this back, and we'd welcome a PR - thank you.

    If you're really, really quick, it just might (no promises) get in to 3.16.2, due to be released later this week.

    All the best,
    David

  2. added
    enhancementNew feature or request
    regriddingRelating to regridding operations
    and removed
    questionGeneral question
    on Apr 25, 2024
  3. added this to the 3.16.2 milestone on Apr 25, 2024
  4. davidhassell commented on Apr 25, 2024

    @davidhassell
    Collaborator

    Closed by merging #768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestregriddingRelating to regridding operations

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions