Skip to content

Support selected new numpy-consistent Data methods #328

Open

Description

@sadielbartholomew

After or during the LAMA to Dask conversion (#182) we should review the Data methods we support, especially because LAMA didn't yet support binary operations in a performant way, but Dask enables those, and particularly also for data operations like mathematical functions where we don't seem to have very good coverage relative to the possible methods supported by NumPy (see ours vs. numpys).

The following can be used as a list of methods to add, or to prioritise adding; please add to the list as appropriate, particularly with user requests or where a method seems particularly useful in the context of cf to add (try to include some contextual notes):

  • arctan2: already largely coded up but commented out as it is a binary operation and therefore was not possible to do in a performant way with the current LAMA (see Support binary operations e.g. arctan2 division #38);
  • sqrt: user request by @bnlawrence (I pointed out f**0.5 works for this, etc., but the method form was preferred and requested);
  • cbrt: why not add if we are adding the above anyway, where all other more niche roots can be covered by the ** operator;
    ...

Activity

  1. davidhassell commented on Feb 28, 2022

    @davidhassell
    Collaborator

    Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions