Skip to content

Unit tests #108

Open
Open
Unit tests#108
Labels
help wanted

Description

@AdamStelmaszczyk
AdamStelmaszczyk
opened on Jun 21, 2018

I was looking for unit tests to understand corner cases + see how many of them are to port to C++. I haven't found any unit test of pommerman forward model logic.

It will be good to have at least regression tests when fixing bugs like: b16c395, 3c06283, 8b57431.

Activity

  1. cinjon commented on Jun 21, 2018

    @cinjon
    cinjon
    on Jun 21, 2018
    Collaborator

    Sigh. It's true. We've been very lax on that and haven't put in the effort to build all the proper unit tests. This would be very helpful as a contribution and probably necessary for #103 .

  2. cinjon
    added
    help wanted
    on Jun 21, 2018

  3. suphoff commented on Aug 4, 2018

    @suphoff
    suphoff
    on Aug 4, 2018
    Contributor

    Once #123 is resolved recorded (state x action -> state) steps can be repeated by different implementations of step functions and compared with the expected state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wanted

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions