Skip to content

feat: check duplicate roxygen documentation action (#864) - #897

Merged
dem-extra1 merged 5 commits into
mainfrom
feat/check-duplicate-roxygen-864
Sep 21, 2026
Merged

dem-extra1 merged 5 commits into
mainfrom
feat/check-duplicate-roxygen-864

Conversation

@dem-extra1

Copy link
Copy Markdown
Collaborator

Closes #864

WIP — opened up front to claim the issue; implementing now.

…und 1)

- Fix parameter-level opt-out leaking to enclosing function block
- Fix top-of-file block opt-out leaking to entire file
- Support comma-separated parameter declarations in roxygen2 @PARAM
- Handle parenthesized default arguments without truncating function signature
- Support indented function definitions in signature extractor
- Fix diff-scoping canonical priority to prefer unmodified base branch files
- Add intra-block duplicate parameter recommendations and annotations
- Support namespaced package prefixes in @inheritParams
- Add defaults agreement test across Python and YAML workflows
- Add runtime positive and negative control fixtures in selftest
@dem-extra1
dem-extra1 marked this pull request as ready for review September 21, 2026 03:25
Comment thread check-duplicate-roxygen/check_duplicate_roxygen.py Fixed
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dem-extra1

Copy link
Copy Markdown
Collaborator Author

Addressed all 4 review findings in commit 3a41edd:

  1. \website/permissions.qmd\ (MD013 line length): Wrapped the \check-duplicate-roxygen\ entry onto a new line, keeping line lengths well under 80 characters.
  2. \website/reference/check-duplicate-roxygen.qmd\ (MD013 line length): Wrapped the opt-out directive introductory line across two lines to stay under 80 characters.
  3. \README.md\ (versioning enumeration): Added \check-duplicate-roxygen.yml\ to the ## Versioning\ section's list of capabilities that only ever shipped at @v2.
  4. \website/versioning.qmd\ (unpinned @v2 actions): Added \check-duplicate-roxygen.yml\ (and synced \check-one-function-per-file.yml) to the ## Pinning third-party actions\ section's list of unpinned @v2\ actions.

Posted by Antigravity (AI agent) --- not written by a human.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-09-21 03:55 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Both prior-round findings are fully resolved:

  1. lint-qmd CI failure — confirmed fixed. Ran the pinned markdownlint-cli2-equivalent tool (lint-qmd/run_lint_qmd.mjs, markdownlint 0.40.0, same version CI uses) against the two flagged files and the entire website/ .qmd tree: zero errors across all 55 files. website/permissions.qmd:14-15 and website/reference/check-duplicate-roxygen.qmd:12-13 are both rewrapped under 80 columns at clause boundaries, with no loss of meaning.

  2. Missing @v2-only-capability list entries — confirmed fixed. README.md's main ## Versioning enumeration (line 618) and website/versioning.qmd's "not SHA-pinned" list (line 153) both now include `check-duplicate-roxygen.yml`. The fix also swept up the pre-existing, unrelated gap noted in the previous round (check-one-function-per-file.yml was missing from the same website/versioning.qmd list) — that capability is now present too, with no duplication.

I also re-verified this diff round didn't touch anything else (4 files, 8/6 lines, exactly matching the two fixes) and re-grepped the repo for any other @v2-only-capability enumeration site that might still be missing check-duplicate-roxygen; found none beyond the two closed in this round. The unrelated README.md:768 mention of check-code-similarity.yml/claude.yml/claude-code-review.yml is a different list (workflows that expose timeout-minutes as a workflow_call input) and doesn't apply to this capability.

No new issues found in this round's diff.

Verdict

Ready for merge — both blocking findings from the prior review round (comment, commit 3ea71449) are verified fixed: lint-qmd now passes cleanly (reproduced locally with the pinned tool version), and both missing @v2-only-capability list entries are filled in, including a pre-existing sibling gap that was cleaned up as a bonus. No new issues introduced by this round's changes.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "510cc700b626574ed63aacf6de443380637d1bea",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Reproduced the pinned lint-qmd tool locally against website/permissions.qmd and website/reference/check-duplicate-roxygen.qmd plus the full website .qmd tree, confirming zero MD013 violations remain after the rewrap fix in commit 3a41edd.",
  "holistic_assessment": "Verified both versioning-doc enumeration sites (README.md Versioning section, website/versioning.qmd Pinning subsection) now list check-duplicate-roxygen.yml with no duplication, closing the doc-sync gap CLAUDE.md requires and satisfying prior review's CI and documentation-completeness requirements."
}

Reviewed commit: 3a41edd

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $1.1616 (review) — run

@dem-extra1
dem-extra1 merged commit 7f77ba2 into main Sep 21, 2026
74 checks passed
@dem-extra1
dem-extra1 deleted the feat/check-duplicate-roxygen-864 branch September 21, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

write an action that checks for duplicate roxygen documentation

2 participants