fix(search): include reaction definitions in quick search - #239
Merged
samseaver merged 3 commits intoSep 8, 2026
Merged
Conversation
Collaborator
Author
|
Hardened after full reaction-search audit in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stoichiometry/equationsearches, while nested Solr parent-scopes result documents and block-joins childcompound/participant_namematchesdefinition), status, EC numbers, aliases, pathways, notes, and stoichiometry; terms are escaped before generated wildcardsfindReactionsForCompound, URL encoding for query fields/sorts, and successful malformed-Solr-response handling without masking HTTP errorsRegression matrix
Decoded request assertions cover legacy and nested schemas; one/multiple quick terms with AND/OR; empty and intentional wildcard queries; prefix threshold; special-character/space escaping; Equation compound ID/name lookup; parent scoping; explicit string/boolean/numeric filters and OR composition; filter + quick search;
queryColumn; directquery; pagination/sort/visible fields; schema detection/cache/failure; endpoint routing; and preserved compound batch behavior.Live reproduction
Manual unauthenticated probes on 2026-09-08:
staging.modelseed.org/solr/reactions_stagingrejectsdoc_type(HTTP 400), proving the legacy path;modelseed.org/solr/reactions_stagingaccepts parentdoc_type:reactionand the established{!parent ... doc_type:stoichiometry ...}join (HTTP 200). Browser/Vitest live integration is CORS-blocked (403 OPTIONS), so contract coverage is deterministic request-level tests.Verification
npx vitest run tests/unit/api/biochemStoichiometry.test.ts tests/unit/api/biochem.test.ts tests/unit/api/solrSchema.test.tsnpm run lintnpx tsc --noEmitnpm run test:runnpm run buildnpm audit --omit=dev --audit-level=highgit diff --check