Update expander.js 0x06 should be 0x0C for pullups - #1689
Closed
Templarian wants to merge 1 commit into
Closed
Conversation
Collaborator
|
It took me a few minutes to remember how this works. ;) It looks like you are correct. I think what happened is that it used the Bank = 1 mode register for GPPUA (0x06) but since the expander runs in Bank = 0 mode, GPPUA is different (0x0C). Thank you! We'll get this merged for the September release. |
Collaborator
|
This has been merged and will be available in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe in both places it should be
0x0C(as0x06is DEFVAL).It works either way with my mcp23017 for interrupts on buttons. Might be why it wasn't noticed.
Still new to this chip so could be reading the library wrong.