Skip to content

fix: continue validating trips after circular trip - #2204

Open
al07mdd wants to merge 1 commit into
MobilityData:masterfrom
al07mdd:fix/trip-headsign-circular-loop
Open

al07mdd wants to merge 1 commit into
MobilityData:masterfrom
al07mdd:fix/trip-headsign-circular-loop

Conversation

@al07mdd

@al07mdd al07mdd commented Sep 25, 2026

Copy link
Copy Markdown

Summary

Fixes #2203. TripHeadsignValidator compared circular-trip stop IDs by object identity and returned from the entire validation method when a loop was found. This change compares IDs by value and skips only the circular trip, so later trips are still checked.

Expected behavior

Two synthetic regression tests cover equal stop IDs held in distinct String objects and an eligible trip after a circular trip. Both tests failed against the base code and pass with this fix. Notice counts may increase for trips that were previously skipped; results across this validator change should be treated as different validation methods.

Checks

  • Full gradlew test --offline --no-daemon passed on JDK 17.
  • The changed Java files are formatted.
  • No documentation change is needed for this internal validator fix.
  • Related issue linked; title follows Conventional Commits.
  • Screenshots are not applicable to a validator rule; the synthetic tests demonstrate the behavior.

@CLAassistant

CLAassistant commented Sep 25, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@emmambd
emmambd requested a review from skalexch September 27, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TripHeadsignValidator can skip later trips after a circular trip

3 participants