Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2203.
TripHeadsignValidatorcompared circular-trip stop IDs by object identity and returned from the entire validation method when a loop was found. This change compares IDs by value and skips only the circular trip, so later trips are still checked.Expected behavior
Two synthetic regression tests cover equal stop IDs held in distinct
Stringobjects and an eligible trip after a circular trip. Both tests failed against the base code and pass with this fix. Notice counts may increase for trips that were previously skipped; results across this validator change should be treated as different validation methods.Checks
gradlew test --offline --no-daemonpassed on JDK 17.