Skip to content

Serve large installer downloads without a write deadline - #739

Merged
SaladDay merged 1 commit into
mainfrom
serve-large-installer-downloads-without-a-write-deadline
Oct 15, 2026
Merged

SaladDay merged 1 commit into
mainfrom
serve-large-installer-downloads-without-a-write-deadline

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

What

  • Core clears the response write deadline before it serves a local native installer archive (D5). The server-wide 30 s WriteTimeout stays for everything else. Node artifacts and the Runtime image are served by the Web service, which has no write timeout; the other Core streams already set bounded deadlines.
  • When claiming the Session's credential returns 409, the installer removes the executor-credential.json it wrote. The message says the Session's install command cannot be used again and that Rotate plus an extracted install, or a new Session, reconnects it (D6).
  • The bootstrap accepts a complete .part after verifying its checksum, so curl no longer prints the 416 line (D7).
  • The bootstrap prints Interrupted; rerun the same command to continue. on Ctrl-C (D8).

Why

Audit findings D5-D8 from the live-injection run.

Verification

  • go test ./services/core/internal/nativeinstaller ./apps/daemon/internal/cli: pass. The new write-deadline test fails without the fix.
  • go vet on both packages and scripts/check-names.py: pass.

Not done

  • D6 Web state: Core's Session read does not say the credential is claimed (the install status is available), so Web cannot show it without a new field. The Executor credentials list exists but cannot tell a claimed key from an issued one, and hiding the command would remove the documented rerun in the original directory. Left out.
  • D8 for the PowerShell bootstrap: left unchanged.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@SaladDay
SaladDay merged commit 72e7329 into main Oct 15, 2026
22 checks passed
@SaladDay
SaladDay deleted the serve-large-installer-downloads-without-a-write-deadline branch October 15, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant