Repository navigation
Let node reruns recover from earlier attempts - #734
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Node reruns and uninstall recover from earlier attempts (review-node F1-F10).
pendingbefore the node step and rewritten without it after registration. A pending record behaves as no record: the rerun fetches with the token, repeats host checks and replaces the record. Records withoutpending(existing nodes) stay registered.drop_runtime_archivesalso drops the partial files.confirm_removed, before the unit or files are touched, so "Nothing was changed" is true.load_manifest,distribution.NoRedirect,install_display.busyand their tests.No new flag, setting or command;
pendingis a record field set only while an attempt is unregistered.Verification
python3 -m unittest discoverin deploy/node: 158 OK (1 skipped, pre-existing)pnpm --filter @oac/web typecheck: OK;vitest run sandbox-page-ownership.test.tsx: OKnode --test website/tests/translations.test.mjs: tests 1-2 pass; test 3 needs vitepress, skippedpython3 scripts/check-names.py: OKNew tests: proxy applied when the node step stops (F1), unregistered attempt pins nothing (F2), changed unit replaced (F3), store kept when Core was never asked (F5), linked store refused before removal (F8).
Need help on this PR? Tag
@codesmith-botwith what you need.