Repository navigation
Keep the installation grant out of process arguments - #718
Merged
SaladDay merged 1 commit intoOct 15, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
keep-the-installation-grant-out-of-process-arguments
branch
from
October 15, 2026 12:36
dbf3645 to
bf67c96
Compare
SaladDay
deleted the
keep-the-installation-grant-out-of-process-arguments
branch
October 15, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The self-hosted install command now passes the installation grant in the
OAC_INSTALL_GRANTenvironment variable instead of the last POSIX argument /-Authorization. POSIX commands start with a space so shells that skip history do.--authorizationand the bootstrap grant parameters are removed with no alias. The installer reads the variable and unsets it first inparseNativeInstall, sostart, the daemon and Harnesses never inherit it. The PowerShell command clears the variable in afinally.Why
Audit F2: the grant sat in argv for the whole run (readable via /proc, saved in shell history). stdin stays with the interactive prompts, so the environment is the transport.
Verification
go vet(services/core nativeinstaller+api, apps/daemon ./...): passgo test ./internal/nativeinstaller/(services/core): pass, includes the real generated POSIX commandgo test ./internal/cli -run NativeInstall(apps/daemon): pass; the new test pins that the grant is taken, absent fromwithNativeEnv, and--authorizationis rejectedpython3 scripts/check-names.py: passnode --test website/tests/translations.test.mjs: tests 1-2 pass; test 3 needs vitepress, skippedSkipped
Web typecheck/vitest/e2e (no node_modules; only fixture strings changed),
scripts/native-onboarding-smoke.mjs(needs a built bundle), Windows PowerShell tests (no Windows host).Need help on this PR? Tag
@codesmith-botwith what you need.