Skip to content

Keep the installation grant out of process arguments - #718

Merged
SaladDay merged 1 commit into
mainfrom
keep-the-installation-grant-out-of-process-arguments
Oct 15, 2026
Merged

SaladDay merged 1 commit into
mainfrom
keep-the-installation-grant-out-of-process-arguments

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

What

The self-hosted install command now passes the installation grant in the OAC_INSTALL_GRANT environment variable instead of the last POSIX argument / -Authorization. POSIX commands start with a space so shells that skip history do. --authorization and the bootstrap grant parameters are removed with no alias. The installer reads the variable and unsets it first in parseNativeInstall, so start, the daemon and Harnesses never inherit it. The PowerShell command clears the variable in a finally.

Why

Audit F2: the grant sat in argv for the whole run (readable via /proc, saved in shell history). stdin stays with the interactive prompts, so the environment is the transport.

Verification

  • go vet (services/core nativeinstaller+api, apps/daemon ./...): pass
  • go test ./internal/nativeinstaller/ (services/core): pass, includes the real generated POSIX command
  • go test ./internal/cli -run NativeInstall (apps/daemon): pass; the new test pins that the grant is taken, absent from withNativeEnv, and --authorization is rejected
  • python3 scripts/check-names.py: pass
  • node --test website/tests/translations.test.mjs: tests 1-2 pass; test 3 needs vitepress, skipped

Skipped

Web typecheck/vitest/e2e (no node_modules; only fixture strings changed), scripts/native-onboarding-smoke.mjs (needs a built bundle), Windows PowerShell tests (no Windows host).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@blacksmith-sh

This comment has been minimized.

@SaladDay
SaladDay force-pushed the keep-the-installation-grant-out-of-process-arguments branch from dbf3645 to bf67c96 Compare October 15, 2026 12:36
@SaladDay
SaladDay merged commit 447dc87 into main Oct 15, 2026
25 checks passed
@SaladDay
SaladDay deleted the keep-the-installation-grant-out-of-process-arguments branch October 15, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant