Repository navigation
Hide the Session log's reason line on phones - #709
Merged
Merged
Conversation
At 390 px the status column left the clamped reason one or two characters ("模…"), and touch has no tooltip. Below 640 px the log shows the status alone; the Session page keeps the reason and its next step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in the post-campaign walk on mx: at 390 px the Session log's status column left the clamped failure or waiting reason one or two characters (
模…), and touch has no tooltip. Below 640 px (the console's phone breakpoint) the log now shows the status alone; the Session page keeps the full reason and next step. Desktop unchanged.Checks: fixture console in zh at 390 px (reason lines
display: none) and 1440 px (unchanged).Need help on this PR? Tag
@codesmith-botwith what you need.