Repository navigation
Remove the /decompile command and everything only it used - #80
Merged
Merged
Conversation
F6 opens a subject's page, and Companion's Search Everywhere finds any class or registered entry, so /decompile was the last path that opened a class from the game. Removed with it: - the command, its target resolver and class name catalog, and their language keys; - OPEN_CLASS, its payload and SourceTargetKind (protocol 31), with the game's side (SourceTarget and its codec) and Companion's (NavigationTargets). No member target was ever sent; - the class-opening half of the game's Companion requests, which now only inspect and focus (CompanionRequests, formerly ClientCodeOpenService in a decompile package). TickDomain duplicated the protocol's Side and is replaced by it. The README and usage docs no longer describe F6 as opening a class. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
/decompilecommand and everything only it used, and one duplicate type. This prepares the mod for the A2 relay (docs/MOD_SIDES.md).Why: F6 opens a subject's page, and Companion's Search Everywhere finds any class or registered entry. That left
/decompileas the last path that opened a class from the game, and it predates subject pages.Removed
DecompileClientCommand,DecompileTargetResolver,ClassNameCatalog, their tests and their language keys.OPEN_CLASSwithOpenClassMessage,OpenClassPayloadandSourceTargetKind(protocol 31; id 2 stays retired). It was registered in both directions, but Companion never sent it.SourceTargetandCompanionSourceTargetCodec, and Companion'sNavigationTargets. The method and field targets were never sent.CompanionRequestsinclient/companion, formerlyClientCodeOpenServicein adecompilepackage.TickDomain: it duplicated the protocol'sSideand is replaced by it.Kept for the dev harness:
CompanionApplication.open(NavigationTarget), used byUiDevHarnessto open a method.Docs: the README and
USAGE.mdno longer describe F6 as opening a class.Tests:
:protocol:test,:mod:testand:companion:testpass locally. 993 lines removed, 64 added.Protocol: 31. The #75 rework also changes the protocol, so whichever lands second takes the next version.
🤖 Generated with Claude Code