Repository navigation
Conversation
…oad without the icon archive - A block whose faces expose fluids or energy differently showed the amounts of the handler without a side, or of one largest face, and grouped faces by what they do alone, so separate storages doing the same merged. Faces now group by their tanks (fluid and capacity, empty ones too) or energy amounts as well, and where they differ, each group shows its own tanks as fluid facts within the section's budget, or its amounts; the largest-face fallback and its "Read through" row are gone. A side that cannot be read leaves the contents shown. - Companion's quick reload of a language file marked the icon archive changed, which captured every model and texture again (about 8 s). The language alone now only has the catalog captured again for its names; textures put in place still mark the archive. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b00d64183d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!access.equals(NOT_EXPOSED)) facts.section(section).text(groups.getFirst().label(), access); | ||
| return; | ||
| } | ||
| int perGroup = Math.max(1, FactSection.MAX_FACTS / groups.size() - 2); |
There was a problem hiding this comment.
When any fluid or energy capability lookup throws, StorageReader.sided catches that failure and leaves groups empty before calling this method. The resulting division by zero adds a second, misleading ArithmeticException to the inspection after the original capability error, contrary to the intended behavior of preserving unsided contents with one reported side-read problem. Return immediately when the group list is empty, or skip write after the guarded read fails.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1e1fa19: write returns at once for no groups; tested, and the test fails without it.
| List<Tank> tanks = new ArrayList<>(); | ||
| List<String> access = new ArrayList<>(); | ||
| int empty = 0; | ||
| for (int tank = 0; tank < Math.min(handler.getTanks(), StorageReader.MAX_TANKS); tank++) { |
There was a problem hiding this comment.
For a side handler exposing more than MAX_TANKS, this loop discards every tank after the first 32 before grouping and truncation reporting. In the common side-only case there are two groups, so perGroup is 62 and the later warning sees a 32-element list as complete: the omitted tanks are silently hidden, and faces differing only after tank 32 can be merged. Retain the handler's total tank count so the output reports the cap and grouping can distinguish truncated views.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not changing this one: a side exposing more than 32 tanks is the same cap StorageReader has always applied to tanks, and the inspection already shows at most 32 per handler. Faces that differ only after tank 32 are not a case worth more code.
| public void languageReloaded() { | ||
| this.catalogs.recapture(); | ||
| this.companionApp.announceInventory(); |
There was a problem hiding this comment.
When the edited language file overrides a translation used by a built-in or mod resource pack's translatable title, the quick reload changes pack.getTitle().getString(), which PackStacks.of publishes to Companion. This path only recaptures the catalog, so Companion keeps the old pack title until an unrelated full reload or reconnect; republish the lightweight pack stack here while continuing to skip the expensive resource snapshot.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1e1fa19: languageReloaded republishes the pack stacks too, which is cheap; only the resource snapshot is skipped.
…shes the packs' titles Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e1fa19374
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ScriptFacts facts) { | ||
| List<SideReader.Group<SideReader.Exposed>> sides = new ArrayList<>(); | ||
| facts.guarded(section, () -> sides.addAll(read.get())); | ||
| if (sides.size() <= 1) contents.run(); |
There was a problem hiding this comment.
When the unsided fluid or energy capability lookup throws, it fails at the first lookup in SideReader.groups; the inner facts.guarded records that failure and leaves sides empty. This condition then runs contents, which performs the same unsided lookup again, and the exception escapes to the outer guard in readBlock, so the inspection reports and logs the same provider failure twice. Track whether the side read succeeded or reuse a single guarded unsided lookup rather than retrying after this failure.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in f0beec9: the side read is no longer guarded on its own, so a failing capability lookup is reported once by the section's guard, and nothing is read again. The empty-groups case cannot arise any more, so that guard and its test are gone.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Fourth PR of the follow-ups plan (
docs/FOLLOW_UPS.md, local on 1.21.1): items 10 and 11, from #56 and #110.What was wrong
StorageReadershowed the handler without a side, or when there was none, the face with the most tanks or capacity, noted as "Read through". Other faces' storages were lost, equal in size or not.SideReadergrouped faces by what they do alone, so a machine whose input and output tanks both take and give water showed one group.resourcesReloaded, which marked the resource snapshot changed and captured every model and texture again, about 8 s.What changes
SideReader.Exposed). Fluids keep each tank's fluid and capacity, empty tanks too. Energy keeps its amounts, such as1,200 / 10,000 FE: takes. Faces of one storage stay one group, and separate storages with different contents are separate groups.contents,Found, "Read through") is gone, for items too. With the sides alike it could only name a face exposing nothing.StorageReadernow writes the side rows of fluids and energy itself, as it already did for items. A failing capability lookup is reported once in its section.TotalDebugClient.languageReloaded. That captures the catalog again for its translated names and tells Companion, and leaves the snapshot (models, textures, atlases, fluid appearances; no language) and the pack stacks alone. Textures put in place still go throughresourcesReloaded. A language request that fell back to a full reload still takes the full path through the reload listener.Tests
SideReaderTest: faces of two storages that do the same but hold different amounts are separate groups; amounts are formatted as grouped numbers of their capacity.:mod:testinspection tests pass.Not checked in a running game: the TotalDebug game connection was down this session. The reader paths need a game with a block exposing different storages per face.
🤖 Generated with Claude Code