Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pelotrio
force-pushed
the
claude/test-suite-jdk
branch
from
October 5, 2026 22:23
02cc002 to
a02dfe5
Compare
LocalIndexTest, RuntimeIndexRecoveryTest and RuntimeIndexServiceTest build, load and replace the index, and each build indexed all 27,837 classes of the JDK: 42 s of the suite. The service takes the JDK packages to index from a package-private constructor; the tests' factory gives java/lang/, Companion's constructor every package. One test builds Companion's own index and finds classes outside java.lang. 42 s become 9 s. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Pelotrio
force-pushed
the
claude/test-suite-jdk
branch
from
October 5, 2026 22:34
a02dfe5 to
58fa6e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M2, second PR, stacked on #140 (plan:
docs/TEST_SUITE.md).What was wrong
LocalIndexTest,RuntimeIndexRecoveryTestandRuntimeIndexServiceTestbuild, load and replace the runtime index. Every build indexed all 27,837 classes of the JDK, which took 42 s of Companion's suite. #140 measured this as the largest cost left.What changes
RuntimeIndexServicetakes the JDK packages to index from its package-private constructor; empty means every package. Companion's public constructor still indexes the whole JDK.RuntimeTestSources.service, which givesjava/lang/.LocalIndexTest.companionsIndexHoldsTheWholeJdkbuilds Companion's own index and findsjava.util.ArrayListandjavax.swing.JComponent, which the slice leaves out.Tests that build their own
ClassIndex(JDT, references, completion) and tests that open a project throughCompanionApplicationare unchanged. #140 madeProjectTreeTestload a cached index.Measured
The three suites take 9 s instead of 42 s, including the whole-JDK test.
🤖 Generated with Claude Code