Skip to content

[JitDiff X64] [hez2010] Support devirtualization for virtual methods that re ... #1947

Description

@MihuBot

Job completed in 16 minutes 33 seconds (remote runner delay: 1 minute 25 seconds).
dotnet/runtime#128702

Main commit: dotnet/runtime@cf6c92e
PR commit: hez2010/runtime@dca1834

Diffs

Found 86 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46549516
Total bytes of diff: 46549251
Total bytes of delta: -265 (-0.00 % of base)
Total relative delta: -0.24
    diff is an improvement.
    relative diff is an improvement.


Top file regressions (bytes):
           8 : System.Private.CoreLib.dasm (0.00 % of base)

Top file improvements (bytes):
        -258 : System.Security.Cryptography.Pkcs.dasm (-0.06 % of base)
         -15 : System.Text.Json.dasm (-0.00 % of base)

3 total files with Code Size differences (2 improved, 1 regressed), 257 unchanged.

Top method regressions (bytes):
           8 (3.70 % of base) : System.Private.CoreLib.dasm - System.Numerics.TotalOrderIeee754Comparer`1[double]:<Compare>g__CompareSignificand|0_2(double,double):int (FullOpts)

Top method improvements (bytes):
         -68 (-6.20 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+RSACmsSignature:SignCore(System.ReadOnlySpan`1[byte],System.Security.Cryptography.HashAlgorithmName,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,System.Security.Cryptography.RSASignaturePadding,byref):bool (FullOpts)
         -54 (-4.26 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+DSACmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -49 (-6.69 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+MLDsaCmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -49 (-6.69 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+SlhDsaCmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -38 (-2.18 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+ECDsaCmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -15 (-1.70 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonNode:ToString():System.String:this (FullOpts)

Top method regressions (percentages):
           8 (3.70 % of base) : System.Private.CoreLib.dasm - System.Numerics.TotalOrderIeee754Comparer`1[double]:<Compare>g__CompareSignificand|0_2(double,double):int (FullOpts)

Top method improvements (percentages):
         -49 (-6.69 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+MLDsaCmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -49 (-6.69 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+SlhDsaCmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -68 (-6.20 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+RSACmsSignature:SignCore(System.ReadOnlySpan`1[byte],System.Security.Cryptography.HashAlgorithmName,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,System.Security.Cryptography.RSASignaturePadding,byref):bool (FullOpts)
         -54 (-4.26 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+DSACmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -38 (-2.18 % of base) : System.Security.Cryptography.Pkcs.dasm - System.Security.Cryptography.Pkcs.CmsSignature+ECDsaCmsSignature:Sign(System.ReadOnlySpan`1[byte],System.String,System.Security.Cryptography.X509Certificates.X509Certificate2,System.Object,bool,byref,byref,byref):bool:this (FullOpts)
         -15 (-1.70 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonNode:ToString():System.String:this (FullOpts)

7 total methods with Code Size differences (6 improved, 1 regressed), 288471 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions